You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "guyinyou (via GitHub)" <gi...@apache.org> on 2023/09/08 07:33:09 UTC
[GitHub] [rocketmq] guyinyou opened a new pull request, #7329: [ISSUE #7328] Convergent thread pool creation
guyinyou opened a new pull request, #7329:
URL: https://github.com/apache/rocketmq/pull/7329
Convergence thread pool creation to facilitate subsequent iteration management
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7328
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #7329: [ISSUE #7328] Convergent thread pool creation
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7329:
URL: https://github.com/apache/rocketmq/pull/7329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7329: [ISSUE #7328] Convergent thread pool creation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7329:
URL: https://github.com/apache/rocketmq/pull/7329#issuecomment-1711304625
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7329](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1941f02) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/6fd0073d6475c539e8f4c30dc4f104a56a21d724?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6fd0073) will **increase** coverage by `0.01%`.
> The diff coverage is `70.00%`.
```diff
@@ Coverage Diff @@
## develop #7329 +/- ##
=============================================
+ Coverage 42.65% 42.67% +0.01%
- Complexity 9466 9474 +8
=============================================
Files 1152 1150 -2
Lines 82726 82711 -15
Branches 10780 10780
=============================================
+ Hits 35286 35294 +8
+ Misses 43028 43001 -27
- Partials 4412 4416 +4
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rocketmq/common/config/AbstractRocksDBStorage.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uZmlnL0Fic3RyYWN0Um9ja3NEQlN0b3JhZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...common/thread/FutureTaskExtThreadPoolExecutor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdGhyZWFkL0Z1dHVyZVRhc2tFeHRUaHJlYWRQb29sRXhlY3V0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ache/rocketmq/common/thread/ThreadPoolMonitor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdGhyZWFkL1RocmVhZFBvb2xNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/rocketmq/common/utils/ThreadUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvVGhyZWFkVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.88% <0.00%> (ø)` | |
| [...apache/rocketmq/store/queue/ConsumeQueueStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0NvbnN1bWVRdWV1ZVN0b3JlLmphdmE=) | `47.63% <0.00%> (ø)` | |
| [...cketmq/broker/schedule/ScheduleMessageService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2NoZWR1bGUvU2NoZWR1bGVNZXNzYWdlU2VydmljZS5qYXZh) | `56.57% <66.66%> (-1.18%)` | :arrow_down: |
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.96% <100.00%> (ø)` | |
| [...roker/client/DefaultConsumerIdsChangeListener.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0RlZmF1bHRDb25zdW1lcklkc0NoYW5nZUxpc3RlbmVyLmphdmE=) | `40.74% <100.00%> (ø)` | |
| [...he/rocketmq/broker/controller/ReplicasManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY29udHJvbGxlci9SZXBsaWNhc01hbmFnZXIuamF2YQ==) | `45.84% <100.00%> (ø)` | |
| ... and [10 more](https://app.codecov.io/gh/apache/rocketmq/pull/7329?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7329/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org