You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/14 22:37:09 UTC

[GitHub] [beam] ihji commented on a change in pull request #13606: [BEAM-11519] Adding PYPI_INSTALL_REQ role and SDK container support

ihji commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r557743925



##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -39,27 +42,31 @@ import (
 
 // TODO(lostluck): 2018/05/28 Extract these from their enum descriptors in the pipeline_v1 proto
 const (
+	URNFileArtifact   = "beam:artifact:type:file:v1"
+	URNPypiInstallReq = "beam:artifact:role:pypi_install_req:v1"
 	URNStagingTo      = "beam:artifact:role:staging_to:v1"
 	NoArtifactsStaged = "__no_artifacts_staged__"
 )
 
+var idCounter uint64

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org