[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1091: [HUDI-389] Fixing Index look up to return right partitions for a given key along with fileId with Global Bloom

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #1091: [HUDI-389] Fixing Index look up to return right partitions for a given key along with fileId with Global Bloom
URL: https://github.com/apache/incubator-hudi/pull/1091#discussion_r357500105
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
 ##########
 @@ -304,6 +304,24 @@ public HoodieRecord generateUpdateRecord(HoodieKey key, String commitTime) throw
     return updates;
   }
 
+  public List<HoodieRecord> generateUpdatesWithDiffPartition(String commitTime, List<HoodieRecord> baseRecords)
 
 Review comment:
   this method uses some variables in HoodieTestDataGenerator. if we move this to the test class, then have to pass in DataGenerator class and hence left it here. If you still persist, I can move it. 
   
   Yes, you are right. To choose the new partition chose, I alter between two partitions. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services