You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/18 21:16:25 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #10356: cache size set by the thread
wcarlson5 opened a new pull request #10356:
URL: https://github.com/apache/kafka/pull/10356
Make is so threads do not directly resize other threads caches
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802393840
@guozhangwang @ableegoldman Can you take a look?
@vvcephei I think this needs to be picked to 2.8 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802411941
One unrelated test failure: `kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoConsumeWithDescribeAclViaAssign`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802493975
Merged and cherrypicked to 2.8 cc @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman edited a comment on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
ableegoldman edited a comment on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802491798
I don't think we should aim to catch things in soak, although I'm not on the side of "we should never catch anything in soak/everything must have an integration test" either. It's just that this particular issue, and this feature in general really, calls for an integration test -- we should be flexing the cache resize codepath in a realistic scenario. I'm happy to leave that as followup work as long as we do get around to it.
This looks good and the build passed so I'll merge this to unblock the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802491798
I don't think we should aim to catch things in soak, although I'm not on the side of "we should never catch anything in soak/everything must have an integration test" either. This particular issue does seem appropriate for an integration test -- as I said concurrency bugs are hard to actually reproduce, but we should absolutely be flexing the cache resize codepath in an integration test. I'm happy to leave that as followup work as long as we do get around to it.
This looks good and the build passed so I'll merge this to unblock the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802427967
I will don't know about testing this via an integration test. I worry about introducing just another flaky test, these types of issue get caught mostly in soak. Even with the optimal conditions for it to go wrong it took a couple days.
I will think about how to improve the tests but that will happen in a different PR for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10356: KAFKA-12503: cache size set by the thread
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10356:
URL: https://github.com/apache/kafka/pull/10356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org