You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/04/03 02:01:30 UTC

[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)

JingsongLi commented on code in PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761#discussion_r1155424491


##########
paimon-core/src/main/java/org/apache/paimon/table/FileStoreTableFactory.java:
##########
@@ -72,6 +72,11 @@ public static FileStoreTable create(FileIO fileIO, Path tablePath, TableSchema t
     public static FileStoreTable create(
             FileIO fileIO, Path tablePath, TableSchema tableSchema, Options dynamicOptions) {
         FileStoreTable table;
+        tableSchema =

Review Comment:
   Can we modify `AbstractFileStoreTable`?
   ```
       public AbstractFileStoreTable(FileIO fileIO, Path path, TableSchema tableSchema) {
           this.fileIO = fileIO;
           this.path = path;
           if (!tableSchema.options().containsKey(PATH.key())) {
               // make sure table is always available
               Map<String, String> newOptions = new HashMap<>(tableSchema.options());
               newOptions.put(PATH.key(), path.toString());
               tableSchema = tableSchema.copy(newOptions);
           }
           this.tableSchema = tableSchema;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org