You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2026/05/13 13:09:54 UTC
(pulsar) 01/02: [fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer (#25596)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch branch-4.2
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 7a7ef8755ad950d3dad35325f2f490d88b927735
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Tue Apr 28 10:47:45 2026 -0700
[fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer (#25596)
(cherry picked from commit d69c78753c5f3747e8d961ee9ba3a419f9c9d8af)
---
.../extensions/ExtensibleLoadManagerImplTest.java | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
index ea417a13c6d..ef71b542b63 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
@@ -1370,10 +1370,15 @@ public class ExtensibleLoadManagerImplTest extends ExtensibleLoadManagerImplBase
assertTrue(pulsar2.getConfiguration().isLoadBalancerServiceUnitTableViewSyncerEnabled()));
makeSecondaryAsLeader();
makePrimaryAsLeader();
- Awaitility.await().atMost(30, TimeUnit.SECONDS)
+ // playLeader()/playFollower() run on a single-threaded loadManagerExecutor, so
+ // playLeader() on the new leader can be queued behind a still-running playFollower()
+ // from the prior demotion. Under CI load this serial chain plus the syncer.start()
+ // work (which opens both table views and runs syncExistingItems/syncTailItems)
+ // can take longer than 30s, so use a more generous timeout here.
+ Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertTrue(primaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
- Awaitility.await().atMost(30, TimeUnit.SECONDS)
+ Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(secondaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
ServiceConfiguration defaultConf = getDefaultConf();
@@ -1582,10 +1587,10 @@ public class ExtensibleLoadManagerImplTest extends ExtensibleLoadManagerImplBase
Awaitility.await().untilAsserted(() ->
assertFalse(pulsar2.getConfiguration().isLoadBalancerServiceUnitTableViewSyncerEnabled()));
makeSecondaryAsLeader();
- Awaitility.await().atMost(30, TimeUnit.SECONDS)
+ Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(primaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
- Awaitility.await().atMost(30, TimeUnit.SECONDS)
+ Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(secondaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
}