[GitHub] [airflow] dstandish commented on a change in pull request #20864: Add support for custom command and args in jobs

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791081240



##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
             "x-docsSection": "Jobs",
             "additionalProperties": false,
             "properties": {
+                "command": {
+                    "description": "Command to use when running create user job (templated).",
+                    "type": [
+                        "array",
+                        "null"
+                    ],
+                    "items": {
+                        "type": "string"
+                    },
+                    "default": null
+                },
+                "args": {
+                    "description": "Args to use when running create user job (templated).",
+                    "type": [
+                        "array",
+                        "null"
+                    ],
+                    "items": {
+                        "type": "string"
+                    },
+                    "default": [
+                        "bash",
+                        "-c",
+                        "exec \\\nairflow {{ semverCompare \">=2.0.0\" .Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+                        "--",
+                        "-r",
+                        "{{ .Values.webserver.defaultUser.role }}",
+                        "-u",
+                        "{{ .Values.webserver.defaultUser.username }}",
+                        "-e",
+                        "{{ .Values.webserver.defaultUser.email }}",
+                        "-f",
+                        "{{ .Values.webserver.defaultUser.firstName }}",
+                        "-l",
+                        "{{ .Values.webserver.defaultUser.lastName }}",
+                        "-p",
+                        "{{ .Values.webserver.defaultUser.password }}"
+                    ]

Review comment:
       no objection from me.  but may be better to just remove the `default` key entirely (though perhaps that's not allowed with our docs build process / pre-commit?)
   
   i looked at the params page, and it is pretty tough to navigate.  probably there is a better way to present this information.  and if that is done, maybe then it's more worthwhile to add.
   
   Along these lines, from code dupe perspective, perhaps defaults could be scraped from values.yaml for the purpose of docs.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org