You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gavinchou (via GitHub)" <gi...@apache.org> on 2024/06/07 15:04:58 UTC

[PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

gavinchou opened a new pull request, #36068:
URL: https://github.com/apache/doris/pull/36068

   Previous implementation does not print txn_id when prepare/commit rowset
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155040702

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155032396

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155028913

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155093521

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40190 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit db46d065d4d4e7782ef8854c429dc63068ef1931, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17622	4345	4231	4231
   q2	2049	197	186	186
   q3	10459	1154	1146	1146
   q4	10203	827	733	733
   q5	7435	2696	2640	2640
   q6	222	139	138	138
   q7	946	603	599	599
   q8	9228	2063	2067	2063
   q9	9041	6468	6484	6468
   q10	8960	3704	3712	3704
   q11	458	237	247	237
   q12	487	224	226	224
   q13	19023	2997	2930	2930
   q14	255	217	218	217
   q15	514	471	476	471
   q16	501	387	366	366
   q17	963	726	681	681
   q18	7958	7474	7228	7228
   q19	1688	1407	1561	1407
   q20	649	316	313	313
   q21	4888	3873	3917	3873
   q22	391	342	335	335
   Total cold run time: 113940 ms
   Total hot run time: 40190 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4311	4276	4201	4201
   q2	379	269	270	269
   q3	2937	2724	3062	2724
   q4	2028	1794	1662	1662
   q5	5538	5481	5498	5481
   q6	220	131	136	131
   q7	2162	1794	1847	1794
   q8	3270	3395	3436	3395
   q9	8818	8785	8971	8785
   q10	4224	3944	3731	3731
   q11	609	481	519	481
   q12	784	642	638	638
   q13	16931	3177	3239	3177
   q14	310	270	267	267
   q15	524	478	499	478
   q16	483	431	429	429
   q17	1821	1533	1543	1533
   q18	8134	7838	7785	7785
   q19	2215	1637	1629	1629
   q20	2182	1894	1865	1865
   q21	5150	4852	4593	4593
   q22	626	540	544	540
   Total cold run time: 73656 ms
   Total hot run time: 55588 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155032334

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155029062

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #36068:
URL: https://github.com/apache/doris/pull/36068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155063571

   TeamCity be ut coverage result:
    Function Coverage: 36.44% (8976/24630) 
    Line Coverage: 27.98% (73367/262195)
    Region Coverage: 27.37% (38015/138871)
    Branch Coverage: 24.00% (19312/80456)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/db46d065d4d4e7782ef8854c429dc63068ef1931_db46d065d4d4e7782ef8854c429dc63068ef1931/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155111131

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172620 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit db46d065d4d4e7782ef8854c429dc63068ef1931, data reload: false
   
   query1	934	396	370	370
   query2	6434	2622	2341	2341
   query3	6633	216	209	209
   query4	19076	17349	17112	17112
   query5	3544	478	451	451
   query6	225	154	159	154
   query7	4514	304	320	304
   query8	341	310	300	300
   query9	8051	2394	2364	2364
   query10	544	305	300	300
   query11	10505	10050	9953	9953
   query12	118	91	80	80
   query13	1548	358	359	358
   query14	10061	7099	6965	6965
   query15	242	181	192	181
   query16	7384	260	258	258
   query17	1474	535	501	501
   query18	1898	268	286	268
   query19	195	150	150	150
   query20	92	79	79	79
   query21	212	134	130	130
   query22	4551	4045	4056	4045
   query23	33487	33445	33519	33445
   query24	11289	2880	2931	2880
   query25	626	374	379	374
   query26	1332	153	162	153
   query27	3104	329	349	329
   query28	7163	2102	2082	2082
   query29	957	623	637	623
   query30	261	158	158	158
   query31	979	742	766	742
   query32	98	55	53	53
   query33	767	294	276	276
   query34	1051	467	491	467
   query35	733	642	612	612
   query36	1080	975	1001	975
   query37	159	77	77	77
   query38	2932	2793	2792	2792
   query39	936	850	841	841
   query40	217	131	129	129
   query41	56	59	54	54
   query42	111	117	108	108
   query43	625	581	587	581
   query44	1235	728	757	728
   query45	205	169	166	166
   query46	1069	703	704	703
   query47	1847	1773	1740	1740
   query48	398	297	295	295
   query49	826	385	395	385
   query50	759	385	406	385
   query51	6816	6609	6609	6609
   query52	105	86	89	86
   query53	355	298	288	288
   query54	814	434	441	434
   query55	78	75	75	75
   query56	265	245	253	245
   query57	1121	1049	1043	1043
   query58	248	232	237	232
   query59	3580	3274	3387	3274
   query60	289	266	261	261
   query61	86	85	113	85
   query62	615	428	443	428
   query63	315	292	295	292
   query64	9300	2213	1728	1728
   query65	3506	3112	3111	3111
   query66	1065	322	323	322
   query67	15254	15030	14798	14798
   query68	4563	523	536	523
   query69	517	412	355	355
   query70	1176	1107	1167	1107
   query71	424	271	258	258
   query72	7098	5315	5402	5315
   query73	746	319	320	319
   query74	5896	5556	5495	5495
   query75	3394	2645	2628	2628
   query76	2295	908	891	891
   query77	428	292	294	292
   query78	10423	9898	9659	9659
   query79	2556	509	513	509
   query80	2368	454	458	454
   query81	580	220	216	216
   query82	1056	100	101	100
   query83	310	166	170	166
   query84	263	88	80	80
   query85	1187	279	256	256
   query86	463	313	307	307
   query87	3288	3112	3048	3048
   query88	3872	2315	2306	2306
   query89	465	370	368	368
   query90	1652	186	182	182
   query91	129	97	96	96
   query92	59	47	53	47
   query93	2032	504	499	499
   query94	1120	179	181	179
   query95	404	364	309	309
   query96	590	264	268	264
   query97	3195	3040	3007	3007
   query98	220	201	202	201
   query99	1095	847	883	847
   Total cold run time: 270554 ms
   Total hot run time: 172620 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [log](cloud) Print txn id when prepare/commit rowset [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36068:
URL: https://github.com/apache/doris/pull/36068#issuecomment-2155119473

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.04 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit db46d065d4d4e7782ef8854c429dc63068ef1931, data reload: false
   
   query1	0.05	0.04	0.03
   query2	0.08	0.03	0.04
   query3	0.23	0.05	0.05
   query4	1.67	0.06	0.07
   query5	0.50	0.50	0.49
   query6	1.14	0.72	0.72
   query7	0.02	0.01	0.02
   query8	0.06	0.05	0.04
   query9	0.54	0.50	0.50
   query10	0.56	0.54	0.56
   query11	0.15	0.11	0.12
   query12	0.14	0.11	0.13
   query13	0.59	0.59	0.60
   query14	0.80	0.76	0.78
   query15	0.82	0.81	0.82
   query16	0.36	0.36	0.35
   query17	1.03	0.98	0.97
   query18	0.22	0.25	0.24
   query19	1.81	1.69	1.70
   query20	0.01	0.01	0.01
   query21	15.41	0.65	0.65
   query22	4.50	7.03	2.44
   query23	18.28	1.32	1.32
   query24	2.08	0.22	0.21
   query25	0.15	0.09	0.08
   query26	0.26	0.17	0.17
   query27	0.08	0.09	0.07
   query28	13.25	1.02	1.00
   query29	12.63	3.28	3.31
   query30	0.25	0.06	0.05
   query31	2.86	0.39	0.38
   query32	3.28	0.48	0.47
   query33	2.86	2.88	2.95
   query34	17.19	4.42	4.44
   query35	4.47	4.46	4.48
   query36	0.64	0.45	0.46
   query37	0.17	0.15	0.16
   query38	0.15	0.15	0.14
   query39	0.04	0.04	0.04
   query40	0.18	0.14	0.17
   query41	0.09	0.05	0.04
   query42	0.05	0.05	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 109.69 s
   Total hot run time: 31.04 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org