[jira] [Commented] (SOLR-9858) Collect aggregated metrics from nodes and shard leaders in overseer

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890212#comment-15890212 ] 

Shalin Shekhar Mangar commented on SOLR-9858:
---------------------------------------------

I reviewed the combined patch and I have a few comments:
# nit-pick typo Mtrics in MetricsCollectorHandler class javadocs
# There should be some protection inside MetricsCollectorHandler in case receiving node is neither leader nor overseer? And when the /admin/metrics/collector replies that it is not in the right role, then we should refresh the overseer/leader url?
# Unrelated changes in SolrClientCache?
# A bunch of tests inside SolrCoreMetricManagerTest.testRegistryName are commented out in the patch
# A new group for replica has been created. If it is to contain the aggregated metrics on the leader, should we call it shard instead?
# Can we extract the default 60s used in SolrMetricManager replica and overseer reporters into a static final constant? Same for SolrOverseerReporter class
# On a related node, we need to add and aggregate disk free stats
# There is no default read or connect timeout specified on http clients created from SolrClientCache. I think we should use the UpdateShardHandler's http client instead.
# I couldn't find anything that prevents the leader itself from instantiating the SolrReplicaReporter to report its own stats to itself?
# I built and ran solr with this patch using bin/solr -e cloud -noprompt which starts 2 nodes and creates a "gettingstarted" collection with 2 shards and 2 replicas. I can't find the "leader" stats for this collection in the /admin/metrics output on either nodes. Then I created a new collection using ./bin/solr create -c xyz -shards 1 -replicationFactor 1 -- for this collection I could find the leader stats under the "overseer" group which is not what I expected. What am I missing?

> Collect aggregated metrics from nodes and shard leaders in overseer
> -------------------------------------------------------------------
>
>                 Key: SOLR-9858
>                 URL: https://issues.apache.org/jira/browse/SOLR-9858
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: master (7.0)
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Minor
>         Attachments: SOLR-9858.patch
>
>
> Overseer can collect metrics from Solr nodes and shard leaders in order to have a notion of the indexing / query / replication / system load on each node, shard and its replicas. This information then can be used for cluster (auto)scaling.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org