You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2001/10/11 16:04:11 UTC
cvs commit: httpd-2.0/modules/proxy mod_proxy.c
wrowe 01/10/11 07:04:11
Modified: modules/proxy mod_proxy.c
Log:
Aye, it's bogus. Something very odd about short terniary results on
this C[++] compiler here, wants to promote to the conditition's type :-/
Revision Changes Path
1.60 +2 -1 httpd-2.0/modules/proxy/mod_proxy.c
Index: mod_proxy.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/proxy/mod_proxy.c,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- mod_proxy.c 2001/09/28 10:33:39 1.59
+++ mod_proxy.c 2001/10/11 14:04:11 1.60
@@ -141,7 +141,8 @@
if (!(r->parsed_uri.hostname
&& !strcasecmp(r->parsed_uri.scheme, ap_http_method(r))
&& ap_matches_request_vhost(r, r->parsed_uri.hostname,
- r->parsed_uri.port_str ? r->parsed_uri.port : ap_default_port(r)))) {
+ (apr_port_t)(r->parsed_uri.port_str ? r->parsed_uri.port
+ : ap_default_port(r))))) {
r->proxyreq = PROXYREQ_PROXY;
r->uri = r->unparsed_uri;
r->filename = apr_pstrcat(r->pool, "proxy:", r->uri, NULL);
Re: cvs commit: httpd-2.0/modules/proxy mod_proxy.c
Posted by Greg Stein <gs...@lyra.org>.
If it is bogus, then *leave a comment*. Somebody down the road is going to
go and nuke that cast, not knowing *why* it should be there. Commentary in a
CVS log entry helps nobody.
Cheers,
-g
On Thu, Oct 11, 2001 at 02:04:11PM -0000, wrowe@apache.org wrote:
> wrowe 01/10/11 07:04:11
>
> Modified: modules/proxy mod_proxy.c
> Log:
> Aye, it's bogus. Something very odd about short terniary results on
> this C[++] compiler here, wants to promote to the conditition's type :-/
>
> Revision Changes Path
> 1.60 +2 -1 httpd-2.0/modules/proxy/mod_proxy.c
>
> Index: mod_proxy.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/proxy/mod_proxy.c,v
> retrieving revision 1.59
> retrieving revision 1.60
> diff -u -r1.59 -r1.60
> --- mod_proxy.c 2001/09/28 10:33:39 1.59
> +++ mod_proxy.c 2001/10/11 14:04:11 1.60
> @@ -141,7 +141,8 @@
> if (!(r->parsed_uri.hostname
> && !strcasecmp(r->parsed_uri.scheme, ap_http_method(r))
> && ap_matches_request_vhost(r, r->parsed_uri.hostname,
> - r->parsed_uri.port_str ? r->parsed_uri.port : ap_default_port(r)))) {
> + (apr_port_t)(r->parsed_uri.port_str ? r->parsed_uri.port
> + : ap_default_port(r))))) {
> r->proxyreq = PROXYREQ_PROXY;
> r->uri = r->unparsed_uri;
> r->filename = apr_pstrcat(r->pool, "proxy:", r->uri, NULL);
>
>
>
--
Greg Stein, http://www.lyra.org/