You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/11/19 22:49:05 UTC
[GitHub] csantanapr closed pull request #147: update tests that use "put" for trigger creation to now use "post"
csantanapr closed pull request #147: update tests that use "put" for trigger creation to now use "post"
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/147
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/packages/CloudantFeedWebTests.scala b/tests/src/test/scala/system/packages/CloudantFeedWebTests.scala
index 46aff32..b1dc009 100644
--- a/tests/src/test/scala/system/packages/CloudantFeedWebTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantFeedWebTests.scala
@@ -58,36 +58,36 @@ class CloudantFeedWebTests
it should "reject put of a trigger due to missing triggerName argument" in {
val params = JsObject(requiredParams.fields - "triggerName")
- makePutCallWithExpectedResult(params, JsObject("error" -> JsString("no trigger name parameter was provided")), 400)
+ makePostCallWithExpectedResult(params, JsObject("error" -> JsString("no trigger name parameter was provided")), 400)
}
it should "reject put of a trigger due to missing host argument" in {
val params = JsObject(requiredParams.fields - "host")
- makePutCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing host parameter")), 400)
+ makePostCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing host parameter")), 400)
}
it should "reject put of a trigger due to missing username argument" in {
val params = JsObject(requiredParams.fields - "username")
- makePutCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing username parameter")), 400)
+ makePostCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing username parameter")), 400)
}
it should "reject put of a trigger due to missing password argument" in {
val params = JsObject(requiredParams.fields - "password")
- makePutCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing password parameter")), 400)
+ makePostCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing password parameter")), 400)
}
it should "reject put of a trigger due to missing dbname argument" in {
val params = JsObject(requiredParams.fields - "dbname")
- makePutCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing dbname parameter")), 400)
+ makePostCallWithExpectedResult(params, JsObject("error" -> JsString("cloudant trigger feed: missing dbname parameter")), 400)
}
it should "reject put of a trigger when authentication fails" in {
- makePutCallWithExpectedResult(requiredParams, JsObject("error" -> JsString("Trigger authentication request failed.")), 401)
+ makePostCallWithExpectedResult(requiredParams, JsObject("error" -> JsString("Trigger authentication request failed.")), 401)
}
it should "reject delete of a trigger due to missing triggerName argument" in {
@@ -100,12 +100,12 @@ class CloudantFeedWebTests
makeDeleteCallWithExpectedResult(requiredParams, JsObject("error" -> JsString("Trigger authentication request failed.")), 401)
}
- def makePutCallWithExpectedResult(params: JsObject, expectedResult: JsObject, expectedCode: Int) = {
+ def makePostCallWithExpectedResult(params: JsObject, expectedResult: JsObject, expectedCode: Int) = {
val response = RestAssured.given()
.contentType(ContentType.JSON)
.config(RestAssured.config().sslConfig(new SSLConfig().relaxedHTTPSValidation()))
.body(params.toString())
- .put(webActionURL)
+ .post(webActionURL)
assert(response.statusCode() == expectedCode)
response.body.asString.parseJson.asJsObject shouldBe expectedResult
}
diff --git a/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala b/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
index 7acfddb..6280d25 100644
--- a/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
@@ -82,13 +82,13 @@ class CloudantMultiWorkersTests extends FlatSpec
wsk.trigger.create(worker10Trigger)
//create trigger feed and assign to worker10
- makePutCallWithExpectedResult(worker10Params, 200)
+ makePostCallWithExpectedResult(worker10Params, 200)
wsk.trigger.create(worker11Trigger)
//create trigger feed and assign to worker10 or worker11
//the one with the least assigned triggers will be chosen
- makePutCallWithExpectedResult(worker11Params, 200)
+ makePostCallWithExpectedResult(worker11Params, 200)
val dbName = s"${dbPrefix}cloudanttrigger"
val documents = getAllDocs(dbName)
@@ -111,12 +111,12 @@ class CloudantMultiWorkersTests extends FlatSpec
}
}
- def makePutCallWithExpectedResult(params: JsObject, expectedCode: Int) = {
+ def makePostCallWithExpectedResult(params: JsObject, expectedCode: Int) = {
val response = RestAssured.given()
.contentType(ContentType.JSON)
.config(RestAssured.config().sslConfig(new SSLConfig().relaxedHTTPSValidation()))
.body(params.toString())
- .put(webActionURL)
+ .post(webActionURL)
assert(response.statusCode() == expectedCode)
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services