You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/12 19:32:18 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3505: Oauth integration

rawlinp commented on a change in pull request #3505: Oauth integration
URL: https://github.com/apache/trafficcontrol/pull/3505#discussion_r293081826
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/login/login.go
 ##########
 @@ -21,8 +21,13 @@ package login
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
+	"github.com/dgrijalva/jwt-go"
 
 Review comment:
   Ok, once the mailing list gives the thumbs up on these new dependencies, we will have to vendor them in our project. I would recommend doing that in a separate PR that just vendors these dependencies. Once that's merged, this PR can merge. Basically, we just `git clone` their repo into one of our vendor directories, and remove their `.git` directory so that git doesn't think it's a sub-repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services