You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2016/12/17 01:43:58 UTC

[jira] [Resolved] (BOOKKEEPER-971) update bk codahale stats provider version

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo resolved BOOKKEEPER-971.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 4.5.0

Issue resolved by merging pull request 83
            [https://github.com/apache/bookkeeper/pull/83]

            {noformat}
            commit be99f024df5d53b3988f585ab46d6b604592acf1
Author:     jiazhai <ji...@emc.com>
AuthorDate: Fri Dec 16 17:43:34 2016 -0800
Commit:     Sijie Guo <si...@apache.org>
CommitDate: Fri Dec 16 17:43:34 2016 -0800

    BOOKKEEPER-971: update bk codahale stats provider version
    
    Update bk stats provider: from codahale to yammer.
    Currently io.dropwizard.metrics 3.1.0 is used most widely. will change version to 3.1.0.
    
    And change CodahaleMetricsProvider.getMetrics() to public, since this would be used outside package.
    
    And a small bug here:
    ```
                File outdir;
                if (Strings.isNullOrEmpty(prefix)) {  < === if (!)
                    outdir = new File(csvDir, prefix);
                } else {
                    outdir = new File(csvDir);
                }
    ```
    
    Author: jiazhai <ji...@emc.com>
    Author: jiazhai <ji...@users.noreply.github.com>
    
    Reviewers: Sijie Guo <si...@apache.org>
    
    Closes #83 from jiazhai/BOOKKEEPER-971

            {noformat}
            

> update bk codahale stats provider version
> -----------------------------------------
>
>                 Key: BOOKKEEPER-971
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-971
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>             Fix For: 4.5.0
>
>
> update bk stats provider: from codahale to yammer.
> Currently io.dropwizard.metrics 3.1.0 is used most widely. will change version to this version, and run the test.
> And would like to change CodahaleMetricsProvider.getMetrics() to public, since this would be used outside package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)