You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "qy-liuhuo (via GitHub)" <gi...@apache.org> on 2024/09/27 12:04:17 UTC
[PR] [INLONG-10463][SDK] Optimization of ultra-long field processing in InlongSDK (Temp) [inlong]
qy-liuhuo opened a new pull request, #11213:
URL: https://github.com/apache/inlong/pull/11213
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #10463
Last Pr: #11119
### Motivation
In #11119 We discussed how to get the `max message size` configuration. Everyone had different ideas. Finally, we decided to temporarily configure it locally in the `DataProxy SDK`.
If the message is longer than the `ConfigConstants.MAX_MESSAGE_LENGTH`, it will directly return `BODY_EXCEED_MAX_LEN` error
### Modifications
- Added `ConfigConstants.MAX_MESSAGE_LENGTH` constant in the `ConfigConstants` file
- Added the `DataBodyUtil` to get the msg size of body or bodyList
- Added logic for handling body length for the `DefaultMessageSender`
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10463][SDK] Optimization of ultra-long field processing in InlongSDK (Temp) [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo closed pull request #11213: [INLONG-10463][SDK] Optimization of ultra-long field processing in InlongSDK (Temp)
URL: https://github.com/apache/inlong/pull/11213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10463][SDK] Optimization of ultra-long field processing in InlongSDK (Temp) [inlong]
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on code in PR #11213:
URL: https://github.com/apache/inlong/pull/11213#discussion_r1794432842
##########
inlong-sdk/dataproxy-sdk/src/main/java/org/apache/inlong/sdk/dataproxy/ConfigConstants.java:
##########
@@ -73,5 +73,6 @@ public class ConfigConstants {
public static String HTTP = "http://";
public static String HTTPS = "https://";
+ public static int MAX_MESSAGE_LENGTH = 500 * 1024;
Review Comment:
Manager already supports configuring the maximum packet length maxPacketLength setting allowed by DataProxy cluster for each {groupId, streamId} [1].
SDK needs to check the length of the reported message based on the maxPacketLength provided by Manager.
1. https://github.com/apache/inlong/pull/11314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10463][SDK] Optimization of ultra-long field processing in InlongSDK (Temp) [inlong]
Posted by "qy-liuhuo (via GitHub)" <gi...@apache.org>.
qy-liuhuo commented on code in PR #11213:
URL: https://github.com/apache/inlong/pull/11213#discussion_r1795035619
##########
inlong-sdk/dataproxy-sdk/src/main/java/org/apache/inlong/sdk/dataproxy/ConfigConstants.java:
##########
@@ -73,5 +73,6 @@ public class ConfigConstants {
public static String HTTP = "http://";
public static String HTTPS = "https://";
+ public static int MAX_MESSAGE_LENGTH = 500 * 1024;
Review Comment:
I have finished it in #11119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org