You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "LinMingQiang (via GitHub)" <gi...@apache.org> on 2025/01/21 05:32:24 UTC
[PR] [flink] Sink.parallelism should be applied to mapToInternalRow operat… [paimon]
LinMingQiang opened a new pull request, #4970:
URL: https://github.com/apache/paimon/pull/4970
…or for appendOnly unwareBucket table.
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
When our source has data skew, rebalancing the data can improve performance.
Especially when some tasks are idle.
Before :
After :
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #4970:
URL: https://github.com/apache/paimon/pull/4970#issuecomment-2606180158
> > Hi @LinMingQiang , it is just a very light conversion, is it really critical for performance?
>
> Yes, the impact is very very small. But this change is positive, so I think it is acceptable.
I think this change bring some overheads to the code complexity. If no visiable impact to performance, I am -1 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #4970:
URL: https://github.com/apache/paimon/pull/4970#issuecomment-2604878627
Hi @LinMingQiang , it is just a very light conversion, is it really critical for performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #4970:
URL: https://github.com/apache/paimon/pull/4970#issuecomment-2605068242
> Hi @LinMingQiang , it is just a very light conversion, is it really critical for performance?
Yes, the impact is very very small. But this change is positive, so I think it is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang closed pull request #4970: [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table.
URL: https://github.com/apache/paimon/pull/4970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "wwj6591812 (via GitHub)" <gi...@apache.org>.
wwj6591812 commented on PR #4970:
URL: https://github.com/apache/paimon/pull/4970#issuecomment-2606013554
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Flink sink.parallelism applies to the mapToInternalRow operator of the appendOnly unwareBucket table. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #4970:
URL: https://github.com/apache/paimon/pull/4970#issuecomment-2606188701
> > > Hi @LinMingQiang , it is just a very light conversion, is it really critical for performance?
> >
> >
> > Yes, the impact is very very small. But this change is positive, so I think it is acceptable.
>
> I think this change bring some overheads to the code complexity. If no visiable impact to performance, I am -1 for this.
Ok i can understand and closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org