[jira] [Commented] (THRIFT-2150) Should windows/config.h define WIN32_LEAN_AND_MEAN?

["James E. King, III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529909#comment-14529909 ] 

James E. King, III commented on THRIFT-2150:
--------------------------------------------

This is a Microsoft build infrastructure issue that is external to the project with plenty of help references readily available on how to resolve it in the including code.  I recommend we close this as no plan to fix and take no action here.

> Should windows/config.h define WIN32_LEAN_AND_MEAN?
> ---------------------------------------------------
>
>                 Key: THRIFT-2150
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2150
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9.1
>         Environment: MSVC
>            Reporter: Chris Stylianou
>              Labels: c++, msvc, thrift, windows
>
> As "windows/config.h" includes Winsock2.h, is it not best practise to define before it: 
> {code}WIN32_LEAN_AND_MEAN{code} 
> This is in case someone includes Windows.h, which automatically includes the incompatible Winsock.h. It also reduces the size of the Win32 header files which helps compilation speeds :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)