[jira] [Commented] (CB-10063) cordova-cli 5.4.0 bug with PList creation

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025800#comment-15025800 ] 

Shazron Abdullah commented on CB-10063:
---------------------------------------

We are alive. 
This might be because the `orientation` preference (by default its "default") is applied *after* your config.xml changes have been applied, clobbering them. (CB-9371)

In 5.4.0, there was a re-factor of some code to a cordova-common library, and it is possible that the order of plist transformations have been changed, not sure yet.

Ideally you would use the `orientation` preference, but you would need CB-9703 

> cordova-cli 5.4.0 bug with PList creation
> -----------------------------------------
>
>                 Key: CB-10063
>                 URL: https://issues.apache.org/jira/browse/CB-10063
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 5.4.0
>            Reporter: Gregor
>
> Our config.xml has this part in:
> {code:java}
>     <platform name="ios">
>       <!-- ios restrictions -->
>       <preference name="target-device" value="universal" />
>       <config-file target="*-Info.plist" parent="UISupportedInterfaceOrientations">
>         <array>
>           <string>UIInterfaceOrientationPortrait</string>
>           <string>UIInterfaceOrientationPortraitUpsideDown</string>
>         </array>
>       </config-file>
>       <config-file target="*-Info.plist" parent="UISupportedInterfaceOrientations~ipad">
>         <array>
>           <string>UIInterfaceOrientationPortrait</string>
>           <string>UIInterfaceOrientationLandscapeLeft</string>
>           <string>UIInterfaceOrientationPortraitUpsideDown</string>
>           <string>UIInterfaceOrientationLandscapeRight</string>
>         </array>
>       </config-file>
>     </platform>
> {code}
> With Cordova 5.4.0 installed, PList gets generated, but there is no part with orientation options in. Removing 5.4.0 and installing 5.3.3, everything functions as should. 
> Looking at update_platform_config.js hook and echoing this line out 
> {code:java}
> fs.writeFileSync(targetFile, tempInfoPlist, 'utf-8');
> {code}
> You will see in console, the part with orientation is in. Also, if you save this exact same string into some new generic file, it will be successfully saved. However, the original platforms/ios/myapp/myapp.plist file won't include the orientation part.
> This is a serious bug and a huge issue for us. Going to buggy 5.3.3 is a huge step down for us, and not having this orientation in 5.4.0 is another.
> I don't know if there's actually anyone alive here, but I surely hope, someone will someday found this ticket and say "hey.. look.. we aren't the only ones that have the problem with the orientation thing on ios"
> Regards.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org