You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/05 10:21:19 UTC

[GitHub] [arrow-datafusion] timvw commented on a diff in pull request #2444: Issue 2321: ehance documentation on how to format/check your code

timvw commented on code in PR #2444:
URL: https://github.com/apache/arrow-datafusion/pull/2444#discussion_r865759797


##########
dev/format-code.sh:
##########
@@ -0,0 +1,22 @@
+#!/bin/bash

Review Comment:
   Personally, I appreciate the fact that multiple steps/commands are visualised as multiple steps/commands in the build pipeline.
   
   The CI build and the dev/lint-code script could be updated to invoke the same scripts (run_clippy.sh, run_xxx, ..) but unless  the commands and/or their arguments change often, I would not bother..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org