[GitHub] [airflow] ferruzzi commented on a diff in pull request #30001: Rename DummyStatsLogger per previous inclusivity push

["ferruzzi (via GitHub)" <gi...@apache.org>]

ferruzzi commented on code in PR #30001:
URL: https://github.com/apache/airflow/pull/30001#discussion_r1131451904


##########
airflow/stats.py:
##########
@@ -182,8 +182,8 @@ def stop(self, send=True):
             self.real_timer.stop()
 
 
-class DummyStatsLogger:
-    """If no StatsLogger is configured, DummyStatsLogger is used as a fallback."""
+class NullStatsLogger:
+    """If no StatsLogger is configured, NullStatsLogger is used as a fallback."""

Review Comment:
   Yeah, I remember that.  I don't know if "Empty" really applies in the case but I can't think of one that feels more accurate... in this case the object/class exists, it just doesn't DO anything...  If nobody comes up with a better-sounding answer, I'll change it to Empty I guess.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org