You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/10/25 16:54:46 UTC
[PR] test: case for write with non ascii code in path [incubator-opendal]
suyanhanx opened a new pull request, #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx closed pull request #3382: test: case for write with non ascii code in path
URL: https://github.com/apache/incubator-opendal/pull/3382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382#issuecomment-1779715994
@Xuanwo We may add a capability for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382#issuecomment-1779736482
> @Xuanwo We may add a capability for this case.
Based on my test on dropbox client, it's ok with non-ascii characters, but not for emojis like 🐂🍺.
So the capability is hard to decide and less useful for end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382#issuecomment-1781049750
> I prefer disable/comment this test case for temporary.
Let's make the test for special characters (ascii only) consistent between the core and bindings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382#issuecomment-1779754796
> This use case is come from [here](https://github.com/apache/incubator-opendal/blob/c5333ea3e76e94201b5110b99093ff08c87fc076/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncWriteTest.java#L94). Whether this use case is needed or not may also require us to confirm.
I prefer disable/comment this test case for temporary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: case for write with non ascii code in path [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3382:
URL: https://github.com/apache/incubator-opendal/pull/3382#issuecomment-1779740633
This use case is come from [here](https://github.com/apache/incubator-opendal/blob/c5333ea3e76e94201b5110b99093ff08c87fc076/bindings/java/src/test/java/org/apache/opendal/test/behavior/AsyncWriteTest.java#L94). Whether this use case is needed or not may also require us to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org