You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/04/30 06:47:57 UTC
[GitHub] [incubator-brpc] renzhong opened a new pull request, #1754: fix auto https check
renzhong opened a new pull request, #1754:
URL: https://github.com/apache/incubator-brpc/pull/1754
[文章](https://github.com/apache/incubator-brpc/blob/master/docs/cn/client.md#%E5%BC%80%E5%90%AFssl) 文档中提到“Channel.Init能自动识别https”，相关功能在去年重构代码中引入了 bug，目前此功能已失效。这个 pt 是为了修复这个问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] renzhong commented on pull request #1754: fix auto https check
Posted by GitBox <gi...@apache.org>.
renzhong commented on PR #1754:
URL: https://github.com/apache/incubator-brpc/pull/1754#issuecomment-1114121294
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren merged pull request #1754: fix auto https check
Posted by GitBox <gi...@apache.org>.
guodongxiaren merged PR #1754:
URL: https://github.com/apache/incubator-brpc/pull/1754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1754: fix auto https check
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on PR #1754:
URL: https://github.com/apache/incubator-brpc/pull/1754#issuecomment-1114021253
感谢发现问题。不过空白符的修改不要提交了，这会让这个修复PR显得没那么干净，没办法快速聚焦到问题代码。
真正需要修改的只有两行代码而已。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1754: fix auto https check
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on PR #1754:
URL: https://github.com/apache/incubator-brpc/pull/1754#issuecomment-1114106449
@renzhong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org