You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2009/10/23 19:02:16 UTC

a few Observer changes

Hi!

I think we have a slight bug in AnnotationUtil#checkQualifierConditions(Annotation...)
We currently only check for Annotation dupplications between 2 'neighbour' qualifiers.
But dupplicated annotations like @Default @Special @Default will not be detected correctly.

I fixed that by creating a Set from the Annotation... and check if the size is still the same.

Another thing which caused problems with the eventing: When do we prune the @Default annotation?
It seems that the current code prunes it in NotificationManager#toQualifierSet and thus the filterObservers cannot find an @Default annotated ObserverMethod.
I now add the @Default if nothing else is specified, so the default lookup mechanism should work again

Another thing concerns the @Any Qualifier. We didn't  check this in NotificationManager.filterByQualifiers
I now hacked the code to also evaluate @Any, would be cool if anyone can take a look at it!

I just do a bit of reformatting and stuff and will check this in today.

LieGrue,
strub