[GitHub] [storm] bipinprasad commented on a change in pull request #3296: [STORM-3661] handle exception when netty server receive unexpected message

[GitBox <gi...@apache.org>]

bipinprasad commented on a change in pull request #3296:
URL: https://github.com/apache/storm/pull/3296#discussion_r446290984



##########
File path: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
##########
@@ -260,7 +260,15 @@ public void channelActive(Channel c) {
 
     @Override
     public void received(Object message, String remote, Channel channel) throws InterruptedException {
-        List<TaskMessage> msgs = (List<TaskMessage>) message;
+        List<TaskMessage> msgs;
+
+        try {
+            msgs = (List<TaskMessage>) message;
+        } catch (ClassCastException e) {
+            LOG.error("Worker netty server receive message other than the expected class List<TaskMessage>", e);

Review comment:
       Will this log display the original exception message string that shows the Class of the offending message?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org