[GitHub] [beam] lostluck commented on pull request #26101: [Go SDK] Timers with new datalayer

["lostluck (via GitHub)" <gi...@apache.org>]

lostluck commented on PR #26101:
URL: https://github.com/apache/beam/pull/26101#issuecomment-1522389858

   > @lostluck could you also take a look now?
   
   Ack will do! Thanks!
   
   > 
   > Regarding the composites, are you proposing a single interface method that would return map[string]TimeDomain? And this method would return just a single KV pair for the built-in timer types (event-time, processing-time) but would be customizable by users in case they want to batch them.
   
   That's right. A single method for the detection interface, and optionally a few reflection based helper functions for the composition bit. Basically it unifies the two current methods by packaging them into a map by default, but are returning the same information: The timer-familyID and its associated domain.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org