You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Peng Chen <ch...@gmail.com> on 2012/06/08 10:33:27 UTC

[Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Hi, all

I had a fix for bug 119912

https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
it is about application crash when undo & redo a split pasted table.

Can anyone help to review the fix?
Thank you!

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Peng Chen <ch...@gmail.com>.
Hi Jurgen,
       You just reviewed 119653 which is not this one, could you please
help to review 119912? Thanks.

2012/6/8 Peng Chen <ch...@gmail.com>

> Jurgen, thank you for review and check in.
>
>
> 2012/6/8 Jürgen Schmidt <jo...@googlemail.com>
>
>> On 6/8/12 10:33 AM, Peng Chen wrote:
>> > Hi, all
>> >
>> > I had a fix for bug 119912
>> >
>> > https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
>> > it is about application crash when undo & redo a split pasted table.
>> >
>> > Can anyone help to review the fix?
>> > Thank you!
>> >
>> done
>>
>> reviewed, built and tested -< patch applied on trunk, no crash anymore
>>
>> Thanks
>>
>> Juergen
>>
>
>

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/8/12 11:35 AM, Jürgen Schmidt wrote:
> On 6/8/12 11:07 AM, Peng Chen wrote:
>> Jurgen, thank you for review and check in.
> 
> well the patch doesn't compile out of the box.
> 
> bSeqDispose is not declared in the scope, I assume you missed something
> in the patch.
> 
> I did a quick test by declaring it in the loop and it worked but I
> assume you declare it in the header (unochart.hxx)
> 
> Let me know

we can chat via IRC or Sametime

Juergen

> 
> Juergen
> 
>>
>> 2012/6/8 Jürgen Schmidt <jo...@googlemail.com>
>>
>>> On 6/8/12 10:33 AM, Peng Chen wrote:
>>>> Hi, all
>>>>
>>>> I had a fix for bug 119912
>>>>
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
>>>> it is about application crash when undo & redo a split pasted table.
>>>>
>>>> Can anyone help to review the fix?
>>>> Thank you!
>>>>
>>> done
>>>
>>> reviewed, built and tested -< patch applied on trunk, no crash anymore
>>>
>>> Thanks
>>>
>>> Juergen
>>>
>>
>

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/8/12 11:35 AM, Jürgen Schmidt wrote:
> On 6/8/12 11:07 AM, Peng Chen wrote:
>> Jurgen, thank you for review and check in.
> 
> well the patch doesn't compile out of the box.
> 
> bSeqDispose is not declared in the scope, I assume you missed something
> in the patch.
> 
> I did a quick test by declaring it in the loop and it worked but I
> assume you declare it in the header (unochart.hxx)

work means it doesn't crash but the chart is not correct after the redo,
it's empty no DatgaRanges defined etc.

Juergen

> 
> Let me know
> 
> Juergen
> 
>>
>> 2012/6/8 Jürgen Schmidt <jo...@googlemail.com>
>>
>>> On 6/8/12 10:33 AM, Peng Chen wrote:
>>>> Hi, all
>>>>
>>>> I had a fix for bug 119912
>>>>
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
>>>> it is about application crash when undo & redo a split pasted table.
>>>>
>>>> Can anyone help to review the fix?
>>>> Thank you!
>>>>
>>> done
>>>
>>> reviewed, built and tested -< patch applied on trunk, no crash anymore
>>>
>>> Thanks
>>>
>>> Juergen
>>>
>>
>

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/8/12 11:07 AM, Peng Chen wrote:
> Jurgen, thank you for review and check in.

well the patch doesn't compile out of the box.

bSeqDispose is not declared in the scope, I assume you missed something
in the patch.

I did a quick test by declaring it in the loop and it worked but I
assume you declare it in the header (unochart.hxx)

Let me know

Juergen

> 
> 2012/6/8 Jürgen Schmidt <jo...@googlemail.com>
> 
>> On 6/8/12 10:33 AM, Peng Chen wrote:
>>> Hi, all
>>>
>>> I had a fix for bug 119912
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
>>> it is about application crash when undo & redo a split pasted table.
>>>
>>> Can anyone help to review the fix?
>>> Thank you!
>>>
>> done
>>
>> reviewed, built and tested -< patch applied on trunk, no crash anymore
>>
>> Thanks
>>
>> Juergen
>>
>

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Peng Chen <ch...@gmail.com>.
Jurgen, thank you for review and check in.

2012/6/8 Jürgen Schmidt <jo...@googlemail.com>

> On 6/8/12 10:33 AM, Peng Chen wrote:
> > Hi, all
> >
> > I had a fix for bug 119912
> >
> > https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
> > it is about application crash when undo & redo a split pasted table.
> >
> > Can anyone help to review the fix?
> > Thank you!
> >
> done
>
> reviewed, built and tested -< patch applied on trunk, no crash anymore
>
> Thanks
>
> Juergen
>

Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)

Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/8/12 10:33 AM, Peng Chen wrote:
> Hi, all
> 
> I had a fix for bug 119912
> 
> https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
> it is about application crash when undo & redo a split pasted table.
> 
> Can anyone help to review the fix?
> Thank you!
> 
done

reviewed, built and tested -< patch applied on trunk, no crash anymore

Thanks

Juergen