You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/21 15:06:05 UTC

[GitHub] [netbeans] sdedic commented on a change in pull request #2694: Allow "Attach sources/javadoc" UIs to be branded out.

sdedic commented on a change in pull request #2694:
URL: https://github.com/apache/netbeans/pull/2694#discussion_r561952894



##########
File path: java/java.j2seplatform/arch.xml
##########
@@ -340,10 +340,55 @@
     </api>
    </li>
   </ul>
+  
+  <api name="API_Ask_attachSourcesQuestion" group="branding" type="export" category="stable">

Review comment:
       BTW It's a question if the `<api name=""` attribute should not contain the Bundle resource path as well, since the `path/to/Bundle:resourceKey` is the actual API identifier.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists