You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/10 16:43:17 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request #5983: Added a log line to HttpUploadServerHandler
JoaoJandre opened a new pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983
### Description
When I was trying to upload volumes using CloudMonkey + cURL, the upload would always timeout and the SSVM would not receive the volume's data, even though it was receiving the HTTP headers. By adding this log line, it was possible to find out that cURL sends, by default, a 'Expect: 100-continue' with the HTTP request, and then wait the SSVM response, which never happens. Therefore, this PR proposes to add this log line in case any problems like that in the future happens, they would be more easily discovered by enabling the TRACE log level in the SSVM.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### How Has This Been Tested?
Uploaded volumes using CMK + cURL and read the SSVM's log files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806939578
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
ok, makes sense @JoaoJandre . Then I would suggest
```suggestion
if(logger.isTraceEnabled()) {
logger.trace(String.format("HTTP request: %s", msg));
}
```
alternative add a higher level, especially if it is meant for operators as well.
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
ok, makes sense @JoaoJandre . Then I would suggest
```suggestion
if (logger.isTraceEnabled()) {
logger.trace(String.format("HTTP request: %s", msg));
}
```
alternative add a higher level, especially if it is meant for operators as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806939578
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
ok, makes sense @JoaoJandre . Then I would suggest
```suggestion
if(logger.isTraceEnabled()) {
logger.trace(String.format("HTTP request: %s", msg));
}
```
alternative add a higher level, especially if it is meant for operators as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038140388
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1037162409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040344011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806900885
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
As mentioned in the PR description, we had a problem while uploading volumes using cURL. However, even after changing the log to TRACE level, it was not possible for operators to see what was going on there. By adding this log, we were able to see which headers were being sent (via cURL and UI), which enabled us to resolve the issue. The log was intended to developers and operators, so they can see what is happening in the SSVM side. They (operators and developers/supporters) can change the log level to `TRACE` and see a little bit more of information regarding the processing in the SSVM. On the other hand, if no LOG is ever generated (the current state of the code), changing the LOG level in Log4J does not help anything, and a developer is required to change the code and patch it in runtime in the SSVM, so one can proceed with the troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038173916
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1037162577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806893326
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
@DaanHoogland would you suggest wrapping it by `logger.isTraceEnabled()?
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
@DaanHoogland would you suggest wrapping it by `logger.isTraceEnabled()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1037477748
<b>Trillian test result (tid-3314)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32768 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5983-t3314-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.60 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.20 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.83 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 56.29 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 33.98 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 77.70 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 150.29 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 270.04 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 141.81 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.71 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.44 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.44 | test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.87 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040620478
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1037162577
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r805641504
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
this line looks good @JoaoJandre , but i suppose you intent is for this line to be used in some way. As a trace line it should not be read by an oprator, but only by a developer or maybe a whitebox tester. In those cases What is the purpose? Not that I -1 this but it seems that a developer would use this to solve a bug which you don't in this PR so it must be here for whitebox testing, right? like performance or completeness of the upload service?
can you expand a little on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036999411
<b>Trillian test result (tid-3306)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35224 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5983-t3306-kvm-centos7.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.56 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.17 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 31.91 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 53.39 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 33.87 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 35.89 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 125.18 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 150.09 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 270.20 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 142.88 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 44.79 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.41 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.41 | test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.81 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806900885
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
As mentioned in the PR description, we had a problem while uploading volumes using cURL. However, even after changing the log to TRACE level, it was not possible for operators to see what was going on there. By adding this log, we were able to see which headers were being sent (via cURL and UI), which enabled us to resolve the issue. The log was intended to developers and operators, so they can see what is happening in the SSVM side. They (operators and developers/supporters) can change the log level to `TRACE` and see a little bit more of information regarding the processing in the SSVM. On the other hand, if no LOG is ever generated (the current state of the code), changing the LOG level in Log4J does not help anything, and a developer is required to change the code and patch it in runtime in the SSVM, so one can proceed with the troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r804835251
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: \n %s", msg));
Review comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040344011
@JoaoJandre there is only one outstanding comment, can you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040586542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038482996
<b>Trillian test result (tid-3320)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31015 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5983-t3320-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_nic | `Error` | 135.33 | test_nic.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040585794
Thanks @JoaoJandre
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806893326
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
@DaanHoogland would you suggest wrapping it by `logger.isTraceEnabled()?
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
@DaanHoogland would you suggest wrapping it by `logger.isTraceEnabled()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036494456
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036530114
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036524386
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036529377
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038140196
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038164131
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1038174211
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1037162409
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806939578
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
ok, makes sense @JoaoJandre . Then I would suggest
```suggestion
if (logger.isTraceEnabled()) {
logger.trace(String.format("HTTP request: %s", msg));
}
```
alternative add a higher level, especially if it is meant for operators as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1036495075
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r804127241
##########
File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: \n %s", msg));
Review comment:
LGTM, but the \n does seem unnecessary.
Can you please remove the break line (\n)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5983: Added a log line to HttpUploadServerHandler
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#issuecomment-1040586542
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org