You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2014/01/21 23:19:42 UTC
Review Request 17158: SENTRY-93: let sentry-solr-binding hand off to solr
for hdfs authentication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17158/
-----------------------------------------------------------
Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
Repository: sentry
Description
-------
This is related to the authentication issues in SENTRY-68.
Before SENTRY-68, the sentry-solr-binding did no hdfs authentication, so there was a race condition between when solr itself would authenticate and when sentry would try to read from hdfs.
The cleanest way to solve this would have been to have sentry call into solr's hdfs authentication code, so as not to duplicate code. The issue there was that solr-core already had a dependency on sentry-binding-solr, so this would create a circular dependency. That dependency has now been eliminated, so we can use the nicer solution.
Diffs
-----
pom.xml 2f70df19f44f4e95f50cb80de0ee2df34c34c552
sentry-binding/sentry-binding-solr/pom.xml 4ed491a9d97fba1566ea9f37ed8b76b76098abf6
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 995f376a80e06f9c2367ea84c0e60f8a454260c4
sentry-tests/sentry-tests-solr/pom.xml 78191145226ec34fec6443bee4dd5c73a94394c5
Diff: https://reviews.apache.org/r/17158/diff/
Testing
-------
Ran the unit tests and e2e tests.
Thanks,
Gregory Chanan
Re: Review Request 17158: SENTRY-93: let sentry-solr-binding hand off to
solr for hdfs authentication
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
> On Feb. 5, 2014, 11:32 p.m., Vamsee Yarlagadda wrote:
> > Ship It!
Greg, Sorry for the delay.
- Vamsee
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17158/#review33737
-----------------------------------------------------------
On Jan. 21, 2014, 10:19 p.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17158/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 10:19 p.m.)
>
>
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This is related to the authentication issues in SENTRY-68.
>
> Before SENTRY-68, the sentry-solr-binding did no hdfs authentication, so there was a race condition between when solr itself would authenticate and when sentry would try to read from hdfs.
>
> The cleanest way to solve this would have been to have sentry call into solr's hdfs authentication code, so as not to duplicate code. The issue there was that solr-core already had a dependency on sentry-binding-solr, so this would create a circular dependency. That dependency has now been eliminated, so we can use the nicer solution.
>
>
> Diffs
> -----
>
> pom.xml 2f70df19f44f4e95f50cb80de0ee2df34c34c552
> sentry-binding/sentry-binding-solr/pom.xml 4ed491a9d97fba1566ea9f37ed8b76b76098abf6
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 995f376a80e06f9c2367ea84c0e60f8a454260c4
> sentry-tests/sentry-tests-solr/pom.xml 78191145226ec34fec6443bee4dd5c73a94394c5
>
> Diff: https://reviews.apache.org/r/17158/diff/
>
>
> Testing
> -------
>
> Ran the unit tests and e2e tests.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 17158: SENTRY-93: let sentry-solr-binding hand off to
solr for hdfs authentication
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17158/#review33737
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Jan. 21, 2014, 10:19 p.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17158/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 10:19 p.m.)
>
>
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This is related to the authentication issues in SENTRY-68.
>
> Before SENTRY-68, the sentry-solr-binding did no hdfs authentication, so there was a race condition between when solr itself would authenticate and when sentry would try to read from hdfs.
>
> The cleanest way to solve this would have been to have sentry call into solr's hdfs authentication code, so as not to duplicate code. The issue there was that solr-core already had a dependency on sentry-binding-solr, so this would create a circular dependency. That dependency has now been eliminated, so we can use the nicer solution.
>
>
> Diffs
> -----
>
> pom.xml 2f70df19f44f4e95f50cb80de0ee2df34c34c552
> sentry-binding/sentry-binding-solr/pom.xml 4ed491a9d97fba1566ea9f37ed8b76b76098abf6
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 995f376a80e06f9c2367ea84c0e60f8a454260c4
> sentry-tests/sentry-tests-solr/pom.xml 78191145226ec34fec6443bee4dd5c73a94394c5
>
> Diff: https://reviews.apache.org/r/17158/diff/
>
>
> Testing
> -------
>
> Ran the unit tests and e2e tests.
>
>
> Thanks,
>
> Gregory Chanan
>
>