You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Patrick Wendell (JIRA)" <ji...@apache.org> on 2010/08/27 01:20:53 UTC
[jira] Created: (AVRO-636) Expose Singleton Method for TracePlugin
Expose Singleton Method for TracePlugin
---------------------------------------
Key: AVRO-636
URL: https://issues.apache.org/jira/browse/AVRO-636
Project: Avro
Issue Type: Sub-task
Reporter: Patrick Wendell
Assignee: Patrick Wendell
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger resolved AVRO-636.
----------------------------------
Resolution: Fixed
Just comitted this; thanks, Patrick.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2, AVRO-636.patch.v3, AVRO-636.patch.v4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Patrick Wendell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Wendell updated AVRO-636:
---------------------------------
Attachment: AVRO-636.patch.v2
This adds synchronized to the two singleton related methods in TracePlugin.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-636:
------------------------------
Fix Version/s: 1.4.1
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Fix For: 1.4.1
>
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2, AVRO-636.patch.v3, AVRO-636.patch.v4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-636) Expose Singleton Method for
TracePlugin
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903173#action_12903173 ]
Philip Zeyliger commented on AVRO-636:
--------------------------------------
You should probably make the set and get methods synchronized here. Otherwise, looks good.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-636) Expose Singleton Method for
TracePlugin
Posted by "Patrick Wendell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903673#action_12903673 ]
Patrick Wendell commented on AVRO-636:
--------------------------------------
accidentally included some extra code there... will upload new patch momentarily.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2, AVRO-636.patch.v3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Patrick Wendell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Wendell updated AVRO-636:
---------------------------------
Attachment: AVRO-636.patch.v3
Fixing small bug in previous version that caused tests to fail
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2, AVRO-636.patch.v3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Patrick Wendell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Wendell updated AVRO-636:
---------------------------------
Attachment: AVRO-636.patch.v1
This patch adds singleton access to the TracePlugin, Includes several unit tests.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-636) Expose Singleton Method for TracePlugin
Posted by "Patrick Wendell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Wendell updated AVRO-636:
---------------------------------
Attachment: AVRO-636.patch.v4
Here is a working patch sans extra code.
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2, AVRO-636.patch.v3, AVRO-636.patch.v4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-636) Expose Singleton Method for
TracePlugin
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903550#action_12903550 ]
Philip Zeyliger commented on AVRO-636:
--------------------------------------
Patrick,
After applying this patch, I'm seeing a test error:
{noformat}
FAILED
expected:<1> but was:<0>
junit.framework.AssertionFailedError: expected:<1> but was:<0>
at org.apache.avro.ipc.trace.TestBasicTracing.testRecursingTrace(TestBasicTracing.java:280)
{noformat}
Could you confirm that this passes the tests?
Thanks!
> Expose Singleton Method for TracePlugin
> ---------------------------------------
>
> Key: AVRO-636
> URL: https://issues.apache.org/jira/browse/AVRO-636
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-636.patch.v1, AVRO-636.patch.v2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.