You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/07 22:45:49 UTC
[GitHub] [spark] huaxingao opened a new pull request, #36109: [SPARK-38825][SQL][tests] Add a test to cover parquet notIn filter
huaxingao opened a new pull request, #36109:
URL: https://github.com/apache/spark/pull/36109
### What changes were proposed in this pull request?
Currently we don't have a test for parquet `notIn` filter, so add a test for this
### Why are the changes needed?
to make tests more complete
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #36109: [SPARK-38825][SQL][TEST] Add a test to cover parquet notIn filter
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #36109:
URL: https://github.com/apache/spark/pull/36109#issuecomment-1092288254
I have tested this manually. I will merge this without pending CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #36109: [SPARK-38825][SQL][TEST] Add a test to cover parquet notIn filter
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #36109:
URL: https://github.com/apache/spark/pull/36109#issuecomment-1092291148
Merged to master/3.3. Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36109: [SPARK-38825][SQL][tests] Add a test to cover parquet notIn filter
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36109:
URL: https://github.com/apache/spark/pull/36109#discussion_r845613636
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala:
##########
@@ -1901,6 +1901,27 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
}
}
}
+
+ test("in and notIn filters") {
Review Comment:
Please add a test prefix, `SPARK-38825: `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #36109: [SPARK-38825][SQL][tests] Add a test to cover parquet notIn filter
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #36109:
URL: https://github.com/apache/spark/pull/36109#issuecomment-1092278105
cc @dongjoon-hyun @viirya @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #36109: [SPARK-38825][SQL][TEST] Add a test to cover parquet notIn filter
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #36109: [SPARK-38825][SQL][TEST] Add a test to cover parquet notIn filter
URL: https://github.com/apache/spark/pull/36109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org