[GitHub] wohali opened a new pull request #387: Fix linter sometimes ignoring errors

[GitBox <gi...@apache.org>]

wohali opened a new pull request #387: Fix linter sometimes ignoring errors
URL: https://github.com/apache/couchdb-documentation/pull/387
 
 
   Recently I've noticed that sometimes, my local `make check` doesn't show any errors, but Travis does.
   
   I finally traced this down to a logic error in how the "ignore errors for the next _n_ lines" parser worked.  Its `IGNORE_ERROR` flag wasn't being cleared if the "ignore errors for the next _n_ lines" directive was invoked, but no error appeared. Now, we always clear that flag correctly, and forcibly clear it when switching files to be 100% sure.
   
   The problem was a Heisenbug because the directory traversal code can traverse directories in different orders, depending on how the `git clone` operation builds the directory tree. Fun!
   
   Ironically, this bug only surfaced because I relaxed the max line length from 80 to 90 characters, so all of the current ignore directives in our code never actually triggered an error that would be cleared.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services