Occasional jcr2spi test failures

[Jukka Zitting <ju...@gmail.com>]

Hi,

Every now and then I see the following jcr2spi test failures on a
clean checkout:

    Tests in error:
      testUpdateRemovesExtraProperty(org.apache.jackrabbit.jcr2spi.UpdateTest)
      testUpdateAddsMissingSubtree(org.apache.jackrabbit.jcr2spi.UpdateTest)

The problem seems to be caused by the test cases automatically
choosing the "security" workspace for the update test. The reason why
the tests only fail occasionally is that currently the ordering of the
string array returned by getAccessibleWorkspaceNames() is not
deterministic.

I can work around the issue by making
RepositoryImpl.getWorkspaceNames() explicitly sort the returned array
of names, but a more proper fix would probably be to ensure that the
workspace selected by UpdateTest is useful for the test.

BR,

Jukka Zitting

Re: Occasional jcr2spi test failures

[Angela Schreiber <an...@day.com>]

Jukka Zitting wrote:

> I can work around the issue by making
> RepositoryImpl.getWorkspaceNames() explicitly sort the returned array
> of names, 

no... thats odd.

> but a more proper fix would probably be to ensure that the
> workspace selected by UpdateTest is useful for the test.

i would suggest to introduce another param for the jcr2spi tests and
adjust the tests according. can you please file an issue?
thanks
angela