You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/15 01:40:27 UTC

Re: Review Request 23414: Unbundling of libev

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review50664
-----------------------------------------------------------



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/23414/#comment88515>

    Just testing the unbundling stuff locally, and came across an issue with libev.
    
    I think you missed updating the CPPFLAGS when using prefix installed libev.
    
    Also, shouldn't we be doing a AC_CHECK_LIB for libev?


- Vinod Kone


On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23414/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 4:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1172
>     https://issues.apache.org/jira/browse/MESOS-1172
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable mesos to build against the system installed version of libev.  
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/Makefile.am 87cf1ae 
>   3rdparty/libprocess/configure.ac 27c6ede 
> 
> Diff: https://reviews.apache.org/r/23414/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>