You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2023/04/26 11:50:56 UTC
[GitHub] [doris] HHoflittlefish777 opened a new pull request, #19118: [Refactor][Load]Unify common part in stream broker S3 load planner
HHoflittlefish777 opened a new pull request, #19118:
URL: https://github.com/apache/doris/pull/19118
# Proposed changes
Issue Number: #18476
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1541199354
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1537118011
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1532372667
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1546680725
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545269606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1536958945
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545271135
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1180052385
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
Sorry,I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.old is plan(TUniqueId loadId, List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded),now plan( loadId),the purpose of this pr is only to unify common part in streamLoad and loadingTask planner,there is no logical modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] freemandealer commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1191955960
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.HashSet;
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
+ this.fileStatusesList = fileStatusesList;
+ this.filesAdded = filesAdded;
+ }
+
+ public abstract TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException;
+
+ public SlotDescriptor slotDescriptorBuilder(DescriptorTable descTable,
+ TupleDescriptor destTupleDesc,
+ TupleDescriptor scanTupleDesc,
+ Column col) {
+ SlotDescriptor slotDesc = descTable.addSlotDescriptor(destTupleDesc);
+ slotDesc.setIsMaterialized(true);
+ slotDesc.setColumn(col);
+ slotDesc.setIsNullable(col.isAllowNull());
+ SlotDescriptor scanSlotDesc = descTable.addSlotDescriptor(scanTupleDesc);
+ scanSlotDesc.setIsMaterialized(true);
+ scanSlotDesc.setColumn(col);
+ scanSlotDesc.setIsNullable(col.isAllowNull());
+ return scanSlotDesc;
+ }
+
+ public void addAndSetSlotDescriptor(DescriptorTable descTable, TupleDescriptor scanTupleDesc) {
+ // Add an implicit container column "DORIS_DYNAMIC_COL" for dynamic columns
+ SlotDescriptor slotDesc = descTable.addSlotDescriptor(scanTupleDesc);
+ Column col = new Column(Column.DYNAMIC_COLUMN_NAME, Type.VARIANT, false, null, false, "",
+ "stream load auto dynamic column");
+ slotDesc.setIsMaterialized(true);
+ // Non-nullable slots will have 0 for the byte offset and -1 for the bit mask
+ slotDesc.setNullIndicatorBit(-1);
+ slotDesc.setNullIndicatorByte(0);
+ slotDesc.setColumn(col);
+ slotDesc.setIsNullable(false);
+ LOG.debug("plan scanTupleDesc{}", scanTupleDesc.toString());
+ }
+
+ public ScanNode scanNodeBuilder(TupleDescriptor scanTupleDesc, Database db, TUniqueId loadId) throws UserException {
+ FileLoadScanNode fileScanNode = new FileLoadScanNode(new PlanNodeId(0), scanTupleDesc);
+ // 1. create file group
+ DataDescription dataDescription = new DataDescription(table.getName(), taskInfo);
+ dataDescription.analyzeWithoutCheckPriv(db.getFullName());
+ BrokerFileGroup fileGroup = new BrokerFileGroup(dataDescription);
+ fileGroup.parse(db, dataDescription);
+ // 2. create dummy file status
+ TBrokerFileStatus fileStatus = new TBrokerFileStatus();
+ if (taskInfo.getFileType() == TFileType.FILE_LOCAL) {
+ fileStatus.setPath(taskInfo.getPath());
+ fileStatus.setIsDir(false);
+ fileStatus.setSize(taskInfo.getFileSize()); // must set to -1, means stream.
+ } else {
+ fileStatus.setPath("");
+ fileStatus.setIsDir(false);
+ fileStatus.setSize(-1); // must set to -1, means stream.
+ }
+ // The load id will pass to csv reader to find the stream load context from new load stream manager
+ fileScanNode.setLoadInfo(loadId, taskInfo.getTxnId(), table, BrokerDesc.createForStreamLoad(),
+ fileGroup, fileStatus, taskInfo.isStrictMode(), taskInfo.getFileType(), taskInfo.getHiddenColumns(),
+ taskInfo.isPartialUpdate());
+ ScanNode scanNode = fileScanNode;
+ scanNode.init(analyzer);
+ scanNode.finalize(analyzer);
+ scanNode.convertToVectorized();
+ return scanNode;
+ }
+
+ public ScanNode scanNodeBuilder(int nextNodeId,
+ TupleDescriptor scanTupleDesc,
+ long loadJobId,
+ long txnId,
+ BrokerDesc brokerDesc,
+ List<BrokerFileGroup> fileGroups,
+ boolean strictMode,
+ int loadParallelism,
+ UserIdentity userInfo) throws UserException {
+ ScanNode scanNode;
+ scanNode = new FileLoadScanNode(new PlanNodeId(nextNodeId), scanTupleDesc);
+ ((FileLoadScanNode) scanNode).setLoadInfo(loadJobId, txnId, table, brokerDesc, fileGroups,
+ fileStatusesList, filesAdded, strictMode, loadParallelism, userInfo);
Review Comment:
we should check fileStatusesList & filesAdded is already set, otherwise print a error log to tell other developer call preparePlan before plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545498124
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1536154335
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1180052385
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
Sorry,I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.old is plan(TUniqueId loadId, List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded),now Plan(loadId)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1180052385
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
Sorry,I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.old is plan(TUniqueId loadId, List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded),now plan(TUniqueId loadId),the purpose of this pr is only to unify common part in streamLoad and loadingTask planner,there is no logical modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1535678563
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1541828466
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545589272
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1535678439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1178531539
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
If we use insert into select to replace current stream load logic, this planner maybe useless....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on a diff in pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #19118:
URL: https://github.com/apache/doris/pull/19118#discussion_r1180052385
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.planner.external;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.BrokerDesc;
+import org.apache.doris.analysis.DataDescription;
+import org.apache.doris.analysis.DescriptorTable;
+import org.apache.doris.analysis.SlotDescriptor;
+import org.apache.doris.analysis.TupleDescriptor;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.load.BrokerFileGroup;
+import org.apache.doris.planner.DataPartition;
+import org.apache.doris.planner.FileLoadScanNode;
+import org.apache.doris.planner.OlapTableSink;
+import org.apache.doris.planner.PlanFragment;
+import org.apache.doris.planner.PlanFragmentId;
+import org.apache.doris.planner.PlanNodeId;
+import org.apache.doris.planner.ScanNode;
+import org.apache.doris.task.LoadTaskInfo;
+import org.apache.doris.thrift.TBrokerFileStatus;
+import org.apache.doris.thrift.TExecPlanFragmentParams;
+import org.apache.doris.thrift.TFileType;
+import org.apache.doris.thrift.TUniqueId;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.List;
+
+public abstract class LoadPlanner {
+
+ private static final Logger LOG = LogManager.getLogger(LoadPlanner.class);
+
+ public List<List<TBrokerFileStatus>> fileStatusesList;
+
+ public int filesAdded;
+
+ protected LoadTaskInfo taskInfo;
+
+ protected OlapTable table;
+
+ // Something useful
+ // ConnectContext here is just a dummy object to avoid some NPE problem, like ctx.getDatabase()
+ protected Analyzer analyzer;
+
+ protected DescriptorTable descTable;
+
+ public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) {
Review Comment:
Sorry,I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1537117930
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 closed pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 closed pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
URL: https://github.com/apache/doris/pull/19118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545021286
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545509936
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545591661
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545496939
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1545218644
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1546782487
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1532374068
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19118: [Refactor][Load]Unify common part in streamLoad and loadingTask planner
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #19118:
URL: https://github.com/apache/doris/pull/19118#issuecomment-1535920453
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org