You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2022/06/19 03:35:13 UTC
[GitHub] [incubator-pagespeed-ngx] icebluey opened a new issue, #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
icebluey opened a new issue, #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749
Nginx version: nginx 861f076eab72
```
gcc -c -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wno-deprecated-declarations -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../modules/ngx_rtmp_module -I ../pcre2/src/ -I ../openssl/.openssl/include -I ../zlib -I /usr/include/libxml2 -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/http/modules/perl -I /usr/include -I ../modules/ngx_pagespeed/psol/include -I ../modules/ngx_pagespeed/psol/include/third_party/chromium/src -I ../modules/ngx_pagespeed/psol/include/third_party/google-sparsehash/src/src -I ../modules/ngx_pagespeed/psol/include/third_party/google-sparsehash/gen/arch/linux/x64/include -I ../modules/ngx_pagespeed/psol/include/third_party/grpc/src/include -I
../modules/ngx_pagespeed/psol/include/third_party/protobuf/src/src -I ../modules/ngx_pagespeed/psol/include/third_party/re2/src -I ../modules/ngx_pagespeed/psol/include/out/Release/obj/gen -I ../modules/ngx_pagespeed/psol/include/out/Release/obj/gen/protoc_out/instaweb -I ../modules/ngx_pagespeed/psol/include/third_party/apr/src/include -I ../modules/ngx_pagespeed/psol/include/third_party/aprutil/src/include -I ../modules/ngx_pagespeed/psol/include/third_party/apr/gen/arch/linux/x64/include -I ../modules/ngx_pagespeed/psol/include/third_party/aprutil/gen/arch/linux/x64/include -I ../modules/ngx_pagespeed/psol/include/url -I src/mail -I src/stream \
-o objs/addon/src/ngx_rewrite_driver_factory.o \
../modules/ngx_pagespeed/src/ngx_rewrite_driver_factory.cc
../modules/ngx_pagespeed/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_set_cache_control(ngx_http_request_t*, char*)’:
../modules/ngx_pagespeed/src/ngx_pagespeed.cc:410:36: error: request for member ‘elts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
410 | if (r->headers_out.cache_control.elts == NULL) {
| ^~~~
../modules/ngx_pagespeed/src/ngx_pagespeed.cc:411:35: error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to ‘ngx_array_t*’
411 | ngx_int_t rc = ngx_array_init(&r->headers_out.cache_control, r->pool,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| ngx_table_elt_t** {aka ngx_table_elt_s**}
In file included from src/core/ngx_core.h:65,
from src/http/ngx_http.h:13,
from ../modules/ngx_pagespeed/src/ngx_pagespeed.h:36,
from ../modules/ngx_pagespeed/src/ngx_pagespeed.cc:29:
src/core/ngx_array.h:32:29: note: initializing argument 1 of ‘ngx_int_t ngx_array_init(ngx_array_t*, ngx_pool_t*, ngx_uint_t, size_t)’
32 | ngx_array_init(ngx_array_t *array, ngx_pool_t *pool, ngx_uint_t n, size_t size)
| ~~~~~~~~~~~~~^~~~~
../modules/ngx_pagespeed/src/ngx_pagespeed.cc:418:22: error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to ‘ngx_array_t*’
418 | ngx_array_push(&r->headers_out.cache_control));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| ngx_table_elt_t** {aka ngx_table_elt_s**}
In file included from src/core/ngx_core.h:65,
from src/http/ngx_http.h:13,
from ../modules/ngx_pagespeed/src/ngx_pagespeed.h:36,
from ../modules/ngx_pagespeed/src/ngx_pagespeed.cc:29:
src/core/ngx_array.h:27:35: note: initializing argument 1 of ‘void* ngx_array_push(ngx_array_t*)’
27 | void *ngx_array_push(ngx_array_t *a);
| ~~~~~~~~~~~~~^
../modules/ngx_pagespeed/src/ngx_pagespeed.cc: In function ‘bool net_instaweb::{anonymous}::ps_get_cache_control(ngx_http_request_t*, GoogleString*)’:
../modules/ngx_pagespeed/src/ngx_pagespeed.cc:442:74: error: request for member ‘elts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
442 | auto ccp = static_cast<ngx_table_elt_t**>(r->headers_out.cache_control.elts);
| ^~~~
../modules/ngx_pagespeed/src/ngx_pagespeed.cc:447:59: error: request for member ‘nelts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
447 | for (ngx_uint_t i = 0; i < r->headers_out.cache_control.nelts; i++) {
| ^~~~~
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/tmp/tmp.JjqdCQRc1i/nginx-861f076eab72'
make: *** [build] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169249549
This tree guys do the job. https://surfcampmaldives.com/
pagespeed MapOriginDomain localhost https://cdn.surfcampmaldives.com;
pagespeed Domain surfcampmaldives.com;
pagespeed LoadFromFile "https://cdn.surfcampmaldives.com" "/var/www/wordpress/";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] janjoosse commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
janjoosse commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1164095016
I have the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1170548947
> Thanks for the heads up, i've added that directive to the list.
>
> Would you mind if i send you an email with the htpasswd credentials to my pagespeed console and give it a look to know if all caching mechanism are set up correctly?
I have an email in the profile.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168719936
Nice! I should remember that for the next time this comes up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169247636
It doesnt work, i already had that directive set up
i'm trying with this: pagespeed MapOriginDomain localhost https://cdn.surfcampmaldives.com;
https://cdn.surfcampmaldives.com/wp-content/themes/uncode/library/js/init.js?ver=114949620' id='uncode-init-js'></script>
<!--4xx status code, preventing rewriting of https://cdn.surfcampmaldives.com/wp-content/themes/uncode/library/js/init.js?ver=114949620-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] eilandert commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
eilandert commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1166679017
@dvershinin, care to do a pull request for headers.patch? ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168695501
<link rel='stylesheet' href='https://goldengem.net/wp-content/plugins/woocommerce-product-bundles/assets/css/frontend/woocommerce.css' type='text/css' media='all'/><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized--><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized-->
--
| <link rel='stylesheet' href='https://goldengem.net/wp-content/themes/uncode.ggem-child/style.css' type='text/css' media='all'/><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized--><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized-->
| <script src='https://goldengem.net/wp-includes/js/jquery/jquery.min.js' id='jquery-core-js'></script><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized--><!--The preceding resource was not rewritten because its domain (goldengem.net) is not authorized-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169626297
@danidorado
Normally I use some like
`pagespeed Domain http*://*.surfcampmaldives.com;`
This covers both versions, http and https and all subdomains
By default pagespeed Domain only covers the http version
Take care of pagespeed LoadFromFile.
When you use it, there is no http request so resources have no http headers.
If pagespeed don't see any cache-control header, then apply a default of 300 (if I remember) so the optimized resource only lives these 300s in the pagespeed cache.
You need to addç
pagespeed LoadFromFileCacheTtlMs implicit_cache_ttl_in_milliseconds;
Or any other custom header (those added to request with the nginx add_header), with
pagespeed AddResourceHeader
In the config you posted I can't see
pagespeed FetchHttps enable;
pagespeed SslCertDirectory directory;
pagespeed SslCertFile file;
https://www.modpagespeed.com/doc/https_support#configuring_ssl_certificates
So maybe these are causing troubles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1163482943
I have the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169887277
This is what i typically have inside a server block for a particular domain
location ~ \.php$ {
include fastcgi_params;
fastcgi_pass unix:/run/php-fpm/www.sock;
fastcgi_intercept_errors off;
fastcgi_param SCRIPT_FILENAME /var/www/wordpress$fastcgi_script_name;
#NGINX FASTCGI-CACHE-HEADERS
fastcgi_cache_bypass $skip_cache;
fastcgi_no_cache $skip_cache;
fastcgi_cache phpcache;
fastcgi_cache_valid 200 301 302 7d;
add_header X-FastCGI-Cache $upstream_cache_status;
#SECURITY HEADERS
add_header X-Frame-Options "SAMEORIGIN";
add_header X-Content-Type-Options "nosniff";
add_header Strict-Transport-Security "max-age=31536000; includeSubDomains; preload";
add_header X-XSS-Protection "1; mode=block" always;
fastcgi_hide_header X-Powered-By;
proxy_pass_header Server;
add_header Referrer-Policy "no-referrer-when-downgrade";
#add_header Content-Security-Policy "default-src 'self' https: data: 'unsafe-inline' 'unsafe-eval';" always;
}
location ~* \.(?:ico|css|js|gif|jpe?g|png|jpg|woff|woff2|ttf|mp4|mov|ogg)$ {
expires 366d;
#expires 1s;
add_header Pragma public;
add_header Cache-Control "public, max-age=31536000";
access_log off;
log_not_found off;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169978609
Well ..... php stuff is not loaded by LoadFromFile
And Pragma header I think is in the default headers pagespeed set.
But in the statics files, think you need to add, for example, a x-content-type-options: nosniff, and you add in the location bloc
add_header x-content-type-options nosniff;
This header is not set in the optimized resources. If you wish to add it to a optimized resource, you need to use
pagespeed AddResourceHeader "x-content-type-options" "nosniff";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1170035189
Thanks for the heads up, i've added that directive to the list.
Would you mind if i send you an email with the htpasswd credentials to my pagespeed console and give it a look to know if all caching mechanism are set up correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169241798
You can try to authorize that domain with:
```
pagespeed Domain https://cdn.surfcampmaldives.com;
```
This will result in the browser attempting to fetch something like `https://cdn.surfcampmaldives.com/wp-content/themes/uncode/library/js/init.js,qver=2122898389.pagespeed.HASH.jm.js`
That should work if your CDN is set up to pull content from your nginx server where the URL would be decoded successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169238004
https://cdn.surfcampmaldives.com/wp-content/themes/uncode/library/js/init.js?ver=2122898389' id='uncode-init-js'></script>
<!--The preceding resource was not rewritten because its domain (cdn.surfcampmaldives.com) is not authorized-->
Any idea why it's not optimizing resources from the CDN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] shigechika commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
shigechika commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1164144963
I found "r->headers_out.cache_control.elts" in diff of nginx-1.22.0/src/http/modules/ngx_http_headers_filter_module.c and nginx-1.23.0/src/http/modules/ngx_http_headers_filter_module.c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169883226
@danidorado
> I had this directive set up inside the http block at nginx.conf file
> pagespeed LoadFromFileCacheTtlMs 31536000000;
That's ok. I mentioned this because I don't see it in the config you posted. Only one apreciation, maybe 1 year is too much time.
That's supposed to be the time pagespeed stores the optimized resource in their cache .
Forgot the LoadFromFile stuff.... for a momment. If you serve a resource with 1 week as cache-control header and is optimized by pagespeed, 2 things go on:
1.- The cache-control for the optimized resource is changed to 1 year (unless you configured pagespeed to preserver the original header)
3.- The original cache-control, 1 week in the example, is taken by pagespeed as the time the resource lives in their cache.
> if i'm not wrong having that TTL set then I could skip doing this part you mentioned, right?
> Or any other custom header (those added to request with the nginx add_header), with
>pagespeed AddResourceHeader
Ummm... Not. That only affect cache-control. If you whish to add a custom header to the resource ( say strict-transport as example) this must be added with `pagespeed AddResourceHeader`.
As far as the resource is loaded from disk and don't have any http headers, when the optimized resource is serverd it only have the default headers pagespeed put in the optimized resource, and strict-transport is not in these defaults, and don't have it even you set an add_header nginx directive.
>pagespeed SslCertDirectory directory;
>pagespeed SslCertFile file;
You are rigth, don't need these directives as far as the request for an optimized resource not file based goes by http, not https.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Danrancan commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Danrancan commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1204055826
> Thanks @oschaaf, I've been able to compile nginx again. Going to test functionality now
How exactly were you able to compile this now? I'm a noob an very confused with this entire conversation. I raised a similar (if not the same) issue [here #1756](https://github.com/apache/incubator-pagespeed-ngx/issues/1756#issue-1323027465), and was told I might find the answer here. But I'm not finding anything. Would you be able to guide me in the right direction as to how to compile this using the patched aarch64 PSOL libraries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1167132866
@oschaaf. I'm happy to give it a try on my servers, let me know how i can proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] eilandert commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
eilandert commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168029872
ok, no sleep! fixed some things.
Packages here:
http://edge.deb.myguard.nl:8888/pool/main/n/nginx/
http://edge.deb.myguard.nl:8888/openssl3/pool/main/n/nginx/
(building in progress right now. please note: edge.deb.myguard.nl is experimental)
Docker here https://hub.docker.com/r/eilandert/nginx-modsecurity3-pagespeed
(currently only the debian ones are with 1.23.0, when all packages are built ubuntu will follow tomorrow)
Some documentation here:
https://deb.myguard.nl/nginx-modules/
Happy testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168707271
Found it!
I knew it was related to the way the SSL works
Adding this line unleashes pagespeed features
pagespeed RespectXForwardedProto on;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168689342
Is it possible that when the HTML is rewritten, ngx_pagespeeed sees the URL of that page as something other than https://shopdiggers.com? Maybe www.shopdiggers.com?
Other than that, your config looks right to me. It might also help to turn on debug:
```
pagespeed EnableFilters debug;
```
and that will annotate your HTML with more details explaining why rewriting is not happening as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1274210169
It's compiled but i can't make js and css minification, probably images
also.
I'm getting this info message for almost all resources
[Mon, 27 Jun 2022 21:52:58 GMT] [Info] [19134] No permission to rewrite '
https://shopdiggers.com/wp-includes/blocks/navigation/view.min.js'
Because i have an AWS ALB in front of the instance i do all the security
layer at the ALB with AWS SSL certificates, so by then traffic goes under
port 80 inside the vpc
I hope someone could through some light about what is going on
This are my global settings
#pagespeed CreateSharedMemoryMetadataCache
"/mnt/ramdisk/pagespeedcache/" 1000000;
#pagespeed DefaultSharedMemoryCacheKB 150000;
pagespeed FileCacheSizeKb 2048000;
pagespeed FileCacheCleanIntervalMs 36000000;
pagespeed FileCacheInodeLimit 500000;
pagespeed LRUCacheKbPerProcess 8192;
pagespeed LRUCacheByteLimit 16384;
pagespeed RedisServer "XXXXXXXXXXXXXXXXXXXXX";
pagespeed RedisDatabaseIndex 5;
pagespeed RedisReconnectionDelayMs 1;
pagespeed RedisTimeoutUs 50;
pagespeed RedisTTLSec 100000;
pagespeed ImplicitCacheTtlMs 31536000000;
pagespeed LoadFromFileCacheTtlMs 31536000000;
pagespeed ImageMaxRewritesAtOnce -1;
pagespeed HttpCacheCompressionLevel 9;
pagespeed StatisticsPath /ngx_pagespeed_statistics;
pagespeed GlobalStatisticsPath /ngx_pagespeed_global_statistics;
pagespeed MessagesPath /ngx_pagespeed_message;
pagespeed ConsolePath /pagespeed_console;
pagespeed AdminPath /pagespeed_admin;
pagespeed GlobalAdminPath /pagespeed_global_admin;
pagespeed IproMaxConcurrentRecordings 0;
pagespeed EnableCachePurge on;
pagespeed PurgeMethod PURGE;
pagespeed Statistics on;
pagespeed StatisticsLogging on;
pagespeed UsePerVhostStatistics on;
pagespeed LogDir /var/log/pagespeed;
pagespeed MessageBufferSize 200000;
pagespeed XHeaderValue "Optimized by Golden Gem";
pagespeed on;
pagespeed FileCachePath "/mnt/ramdisk/pagespeedcache/";
pagespeed EnableFilters insert_dns_prefetch;
pagespeed EnableFilters extend_cache;
pagespeed EnableFilters strip_image_meta_data;
pagespeed EnableFilters jpeg_subsampling;
pagespeed EnableFilters hint_preload_subresources;
pagespeed UseNativeFetcher on;
pagespeed FetcherTimeoutMs 2000;
pagespeed RewriteDeadlinePerFlushMs 5;
resolver 8.8.8.8;
This are my settings at the VHOST
server {
#listen 443 ssl http2;
#listen [::]:443 ssl http2;
listen 80;
server_name shopdiggers.com;
root /var/www/shopdiggers;
index index.php index.html index.htm;
expires $expires;
location / {
try_files $uri $uri/ /index.php?$args;
}
# Needs to exist and be writable by nginx. Use tmpfs for best performance.
pagespeed RedisReconnectionDelayMs 500;
pagespeed ImplicitCacheTtlMs 31536000000;
pagespeed LoadFromFileCacheTtlMs 31536000000;
# Ensure requests for pagespeed optimized resources go to the pagespeed
handler
# and no extraneous headers get set.
location ~ "\.pagespeed\.([a-z]\.)?[a-z]{2}\.[^.]{10}\.[^.]+" {
add_header "" "";
}
location ~ "^/pagespeed_static/" { }
location ~ "^/ngx_pagespeed_beacon$" { }
pagespeed on;
pagespeed MaxCombinedJsBytes 300000;
pagespeed MaxCombinedCssBytes -1;
pagespeed MaxSegmentLength 1500;
#pagespeed UseExperimentalJsMinifier on;
pagespeed CombineAcrossPaths on;
#pagespeed SslCertDirectory /etc/sslmate/;
#pagespeed SslCertFile shopdiggers.com.chained.crt;
pagespeed FetchHttps
enable,allow_self_signed,allow_unknown_certificate_authority,allow_certificate_not_yet_valid;
pagespeed MapOriginDomain http://shopdiggers.com https://shopdiggers.com;
pagespeed Domain shopdiggers.com;
pagespeed LoadFromFile "https://shopdiggers.com" "/var/www/shopdiggers/";
pagespeed EnableFilters strip_image_color_profile;
pagespeed EnableFilters
move_css_to_head,move_css_above_scripts,flatten_css_imports;
pagespeed EnableFilters rewrite_javascript,rewrite_css,rewrite_images;
pagespeed EnableFilters combine_javascript,combine_css;
pagespeed EnableFilters collapse_whitespace,elide_attributes;
pagespeed EnableFilters remove_comments;
pagespeed EnableFilters inline_google_font_css;
pagespeed EnableFilters sprite_images;
pagespeed EnableFilters extend_cache;
pagespeed EnableFilters insert_dns_prefetch;
pagespeed EnableFilters trim_urls;
On Tue, Jun 28, 2022 at 4:23 AM Thijs Eilander ***@***.***>
wrote:
> ok, no sleep! fixed some things.
>
> Packages here:
> http://edge.deb.myguard.nl:8888/pool/main/n/nginx/
> http://edge.deb.myguard.nl:8888/openssl3/pool/main/n/nginx/
> (building in progress right now. please note: edge.deb.myguard.nl is
> experimental)
>
> Docker here
> https://hub.docker.com/r/eilandert/nginx-modsecurity3-pagespeed
> (currently only the debian ones are with 1.23.0, when all packages are
> built ubuntu will follow tomorrow)
>
> Some documentation here:
> https://deb.myguard.nl/nginx-modules/
>
> Happy testing
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168029872>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABTZ2OMROI6AXFG5REB7PHLVRIZXNANCNFSM5ZFWIKDA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] oschaaf commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
oschaaf commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1167015184
@eilandert & @Lofesa -- https://github.com/apache/incubator-pagespeed-ngx/pull/1750 has an (untested) draft that aims to resolve this. It's still a draft, because we probably need some ifdef's to make the change conditional (I guess older nginx versions swill still need the old way of manipulating cache control headers).
Anyone willing to take that change for a spin? I'd be happy to hear if it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] eilandert commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
eilandert commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1167881999
Thanks @oschaaf , it compiles.
However, my build fails thanks to openresty unpatched modules (with the same problem), so I have no packages at all to test. And I need those to run on my staging environments :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] oschaaf closed issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
oschaaf closed issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168892281
@jmarantz
Is a know trick when you have
user -> 443 -> Proxy -> 80 -> Backend
w/o pagespeed RespectXForwardedProto on; pagespeed respond with the protocol that the proxy request..
Other software have similar issues with this, like Fail2ban.
Fail2ban is a software to ban ip for bad actors and ir works reading log files, so must run in the backend server, but w/o apropiate headers, the log file only record the proxy ip.
In this case headers like X-Real-IP and/or X-Forwarded-For must be inplace and then the real user ip gets recorden in the backend server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] luispabon commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
luispabon commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1162856051
Facing the same issue. This project is abandonded though isnt' it? No commits for 2 years now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] eilandert commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
eilandert commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1163631854
Changes with nginx 1.23.0 21 Jun 2022
*) Change in internal API: now header lines are represented as linked
lists.
I suspect this is the issue here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1170999534
Is there anyway to enable serialization and compression when using pagespeed and redis?
In two days has filled my redis instance
I have set redis for wordpress with igbinary and lz4 support so a redis DDBB of 1GB is typically now around 200MB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1170213494
what about this?
needs to be added at pagespeed as well?
location ~* \.(eot|otf|ttf|woff|woff2)$ {
add_header Access-Control-Allow-Origin *;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1169715900
@Lofesa
I had this directive set up inside the http block at nginx.conf file
pagespeed LoadFromFileCacheTtlMs 31536000000;
if i'm not wrong having that TTL set then I could skip doing this part you mentioned, right?
_Or any other custom header (those added to request with the nginx add_header), with
pagespeed AddResourceHeader_
I read on the documentation pagespeed FetchHttps enable; is enabled by default but i've added to the set up at the http nginx block
In relation to this two directives:
pagespeed SslCertDirectory directory;
pagespeed SslCertFile file;
I'm exactly doing what you mentioned here
AWS ACM -> ALB -> EC2 -> NGINX
user -> 443 -> Proxy -> 80 -> Backend
So i'm not installing certs directly on the instance, instead they are attached to the ALB through AWS console so i have that line that i guess resolves that
pagespeed RespectXForwardedProto on;
And btw, is anyone willing to spend 30-60 minutes on a call to review the integration and give some feedback.
-open to another suitable way to do this without taking too much time of your lives-
I'm happy to pay for that time if neccessary.
I have some doubts if i have properly set up the caching mechanisms and also related to the data shown at the pagespeed console panel.
Thanks for letting me know if i'm doing it right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1170538808
> what about this?
>
> needs to be added at pagespeed as well?
>
> ```
> location ~* \.(eot|otf|ttf|woff|woff2)$ {
> add_header Access-Control-Allow-Origin *;
> }
> ```
Not. As far as pagespeed do nothing with these files (same with .svg and .ico files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1168503753
It's compiled but i can't make js and css minification, probably images also.
I'm getting this info message for almost all resources
[Mon, 27 Jun 2022 21:52:58 GMT] [Info] [19134] No permission to rewrite 'https://shopdiggers.com/wp-includes/blocks/navigation/view.min.js'
Because i have an AWS ALB in front of the instance i do all the security layer at the ALB with AWS SSL certificates, so by then traffic goes under port 80 inside the vpc
I hope someone could through some light about what is going on
This are my global settings
pagespeed CreateSharedMemoryMetadataCache "/mnt/ramdisk/pagespeedcache/" 2048000;
pagespeed DefaultSharedMemoryCacheKB 2048000;
pagespeed FileCacheSizeKb 2048000;
pagespeed FileCacheCleanIntervalMs 36000000;
pagespeed FileCacheInodeLimit 500000;
pagespeed LRUCacheKbPerProcess 8192;
pagespeed LRUCacheByteLimit 16384;
pagespeed RedisServer "XXXXXXXXXXXXXXXXXXXXX";
pagespeed RedisDatabaseIndex 5;
pagespeed RedisReconnectionDelayMs 1;
pagespeed RedisTimeoutUs 50;
pagespeed RedisTTLSec 100000;
pagespeed ImplicitCacheTtlMs 31536000000;
pagespeed LoadFromFileCacheTtlMs 31536000000;
pagespeed ImageMaxRewritesAtOnce -1;
pagespeed HttpCacheCompressionLevel 9;
pagespeed StatisticsPath /ngx_pagespeed_statistics;
pagespeed GlobalStatisticsPath /ngx_pagespeed_global_statistics;
pagespeed MessagesPath /ngx_pagespeed_message;
pagespeed ConsolePath /pagespeed_console;
pagespeed AdminPath /pagespeed_admin;
pagespeed GlobalAdminPath /pagespeed_global_admin;
pagespeed IproMaxConcurrentRecordings 0;
pagespeed EnableCachePurge on;
pagespeed PurgeMethod PURGE;
pagespeed Statistics on;
pagespeed StatisticsLogging on;
pagespeed UsePerVhostStatistics on;
pagespeed LogDir /var/log/pagespeed;
pagespeed MessageBufferSize 200000;
pagespeed XHeaderValue "Optimized by Golden Gem";
pagespeed on;
pagespeed FileCachePath "/mnt/ramdisk/pagespeedcache/";
pagespeed EnableFilters insert_dns_prefetch;
pagespeed EnableFilters extend_cache;
pagespeed EnableFilters strip_image_meta_data;
pagespeed EnableFilters jpeg_subsampling;
pagespeed EnableFilters hint_preload_subresources;
pagespeed UseNativeFetcher on;
pagespeed FetcherTimeoutMs 2000;
pagespeed RewriteDeadlinePerFlushMs 5;
resolver 8.8.8.8;
This are my settings at the VHOST
server {
#listen 443 ssl http2;
#listen [::]:443 ssl http2;
listen 80;
server_name [shopdiggers.com](http://shopdiggers.com/);
root /var/www/shopdiggers;
index index.php index.html index.htm;
expires $expires;
location / {
try_files $uri $uri/ /index.php?$args;
}
# Needs to exist and be writable by nginx. Use tmpfs for best performance.
pagespeed RedisReconnectionDelayMs 500;
pagespeed ImplicitCacheTtlMs 31536000000;
pagespeed LoadFromFileCacheTtlMs 31536000000;
# Ensure requests for pagespeed optimized resources go to the pagespeed handler
# and no extraneous headers get set.
location ~ "\.pagespeed\.([a-z]\.)?[a-z]{2}\.[^.]{10}\.[^.]+" {
add_header "" "";
}
location ~ "^/pagespeed_static/" { }
location ~ "^/ngx_pagespeed_beacon$" { }
pagespeed on;
pagespeed MaxCombinedJsBytes 300000;
pagespeed MaxCombinedCssBytes -1;
pagespeed MaxSegmentLength 1500;
#pagespeed UseExperimentalJsMinifier on;
pagespeed CombineAcrossPaths on;
pagespeed FetchHttps enable,allow_self_signed,allow_unknown_certificate_authority,allow_certificate_not_yet_valid;
pagespeed MapOriginDomain http://shopdiggers.com/ https://shopdiggers.com/;
pagespeed Domain [shopdiggers.com](http://shopdiggers.com/);
pagespeed LoadFromFile "https://shopdiggers.com/" "/var/www/shopdiggers/";
pagespeed EnableFilters strip_image_color_profile;
pagespeed EnableFilters move_css_to_head,move_css_above_scripts,flatten_css_imports;
pagespeed EnableFilters rewrite_javascript,rewrite_css,rewrite_images;
pagespeed EnableFilters combine_javascript,combine_css;
pagespeed EnableFilters collapse_whitespace,elide_attributes;
pagespeed EnableFilters remove_comments;
pagespeed EnableFilters inline_google_font_css;
pagespeed EnableFilters sprite_images;
pagespeed EnableFilters extend_cache;
pagespeed EnableFilters insert_dns_prefetch;
pagespeed EnableFilters trim_urls;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1164265156
@oschaaf Can take alook here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] danidorado commented on issue #1749: incubator-pagespeed-ngx-module not compatible with nginx 1.23.0
Posted by GitBox <gi...@apache.org>.
danidorado commented on issue #1749:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1749#issuecomment-1164308050
I hope this issue push an effort of developing a stable version again as the module for nginx has been in RC1 for years.
The issue with the "double compression and mess with brotli and gzip" has been around since then i had to switch off pagespeed more than a year ago due those content enconding issues that were not allowing the browser to properly render CSS files even enabling this directive ModPagespeedHttpCacheCompressionLevel 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org