You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by jianqiao <gi...@git.apache.org> on 2017/09/01 18:36:25 UTC

[GitHub] incubator-quickstep pull request #292: Redirect stdout and stderr in network...

GitHub user jianqiao opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/292

    Redirect stdout and stderr in network mode.

    This PR redirects `stdout / stderr` to `io_handle->out() / io_handle->err()` (see [here](https://github.com/apache/incubator-quickstep/blob/fb9f856a78d947647406f661f3f3291e294bd266/cli/QuickstepCli.cpp#L309)) for transmitting the standard stream outputs to client in the network mode. It allows `quickstep_client` to use `COPY ... TO stdout ...` command to retrieve result table in CSV format.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep redirect-stream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit fb9f856a78d947647406f661f3f3291e294bd266
Author: Jianqiao Zhu <ji...@cs.wisc.edu>
Date:   2017-09-01T17:07:13Z

    Redirect stdout and stderr in network mode.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #292: Redirect stdout and stderr in network...

Posted by zuyu <gi...@git.apache.org>.

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/292#discussion_r136648903
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -150,6 +152,7 @@ DEFINE_string(mode, "local",
                   "same manner as with the local cli.");
     
     DECLARE_bool(profile_and_report_workorder_perf);
    +DECLARE_bool(timing);
    --- End diff --
    
    No needs for this line. Already included in the header file `cli/Flags.hpp`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #292: Redirect stdout and stderr in network mode.

Posted by zuyu <gi...@git.apache.org>.

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/292
  
    LGTM!


---

[GitHub] incubator-quickstep pull request #292: Redirect stdout and stderr in network...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/292


---