[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3170: [HOTFIX]fixed loading issue for legacy store

[GitBox <gi...@apache.org>]

qiuchenjian commented on a change in pull request #3170: [HOTFIX]fixed loading issue for legacy store
URL: https://github.com/apache/carbondata/pull/3170#discussion_r270618511
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java
 ##########
 @@ -84,19 +84,20 @@ private void addDimensions(List<CarbonDimension> dimensions) {
     List<DimensionSpec> dictDimensionSpec = new ArrayList<>();
     int dimIndex = 0;
     DimensionSpec spec;
-    short actualPosition = 0;
+    short dictActualPosition = 0;
+    short noDimActualPosition = 0;
     // sort step's output is based on sort column order i.e sort columns data will be present
     // ahead of non sort columns, so table spec also need to add dimension spec in same manner
     for (int i = 0; i < dimensions.size(); i++) {
       CarbonDimension dimension = dimensions.get(i);
       if (dimension.isComplex()) {
-        spec = new DimensionSpec(ColumnType.COMPLEX, dimension, actualPosition++);
+        spec = new DimensionSpec(ColumnType.COMPLEX, dimension, (short) 0);
 
 Review comment:
   Why is it '0' ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services