You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2019/04/04 16:48:55 UTC

[GitHub] [royale-asjs] carlosrovira commented on issue #410: fix removeElement if child has 'other' positioner

carlosrovira commented on issue #410: fix removeElement if child has 'other' positioner
URL: https://github.com/apache/royale-asjs/pull/410#issuecomment-479976567
 
 
   Hi Taro,
   
   the PR is just this part: "fix removeElement if child has 'other' positioner" right?
   this was included by mistake: "Merge pull request #2 from apache/develop" ?
   thanks
   
   @aharui : I'm testing to remove a Jewel Textinput and I found this issue. Do you think is ok that in UIBase line 1380
   
   `element.removeChild(c.element as HTMLElement);`
   
   should be:
   
   `element.removeChild(c.positioner as HTMLElement);`
   
   thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services