You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Ralf S. Engelschall" <rs...@engelschall.com> on 2000/08/26 21:41:25 UTC
Re: cvs commit: apache-1.3 configure
In article <20...@locus.apache.org> you wrote:
> [...]
> Allow modules to be named *.so
> (like in:
> --activate-module=src/modules/xxx/libxxx.so
> [...]
> @@ -297,9 +297,14 @@
> module=`echo "$module" |\
> sed -e 's%^.*/\(.*\)$%\1%' \
> -e 's/\.[oa]$//' \
> + -e 's/\.so$//' \
> -e 's/\.module$//' \
> -e 's/^mod_//' \
> -e 's/^lib//'`
> + case $module in
> + *.*) echo "configure:Error: module name must end in .o|.a|.so|.module" 1>&2
> + exit 1;;
> + esac
> eval "module_$module=$add"
> eval "shared_$module=$share"
> modules="${modules}:$module"
Sorry, Martin, I'm have to be -1 on this patch for the following reasons:
1. The patch is inside the Configuration.tmpl parsing loop and this way is
more or less useless because the distributed Configuration.tmpl file
doesn't have any *.so names.
2. Your example --activate-module=src/modules/xxx/libxxx.so is not
affected by this patch, because --activate-module and --add-module
options are implemented a lot later in the configure script.
3. I do not understand what a --activate-module=src/modules/xxx/libxxx.so
should do. The .[ao] -> .so step is done by configure automatically
because of --enable-shared, so usually there is never a configured
src/modules/xxx/libxxx.so path, even if the module exists.
4. The error message talks about ".o|.a|.so|.module", but the actual
check is for a superset "*.*". This is slightly inconsistent.
So, I think the applied patch is functionality wise useless and this way
should be backed out. But if you describe what you are actually trying to
achieve we can help you to come up with a better patch.
Ralf S. Engelschall
rse@engelschall.com
www.engelschall.com