[GitHub] [hudi] yanghua commented on a change in pull request #2539: [HUDI-1584] Modify maker file path, which should start with the target base path.

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #2539:
URL: https://github.com/apache/hudi/pull/2539#discussion_r571389093



##########
File path: hudi-flink/src/main/java/org/apache/hudi/operator/InstantGenerateOperator.java
##########
@@ -297,4 +297,16 @@ private void cleanMarkerDir(Path instantMarkerFolder) throws IOException {
       fs.delete(fileStatus.getPath(), true);
     }
   }
+
+  private Path generateCurrentMakerPath() {
+    String baseDir = cfg.targetBasePath.endsWith("/")

Review comment:
       Do you check if hadoop `new Path(xxx, xxx)` could handle the slash intelligently?

##########
File path: hudi-flink/src/main/java/org/apache/hudi/operator/InstantGenerateOperator.java
##########
@@ -297,4 +297,16 @@ private void cleanMarkerDir(Path instantMarkerFolder) throws IOException {
       fs.delete(fileStatus.getPath(), true);
     }
   }
+
+  private Path generateCurrentMakerPath() {

Review comment:
       IMO, `generateCurrentMakerDirPath ` sounds better?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org