You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Arina Ielchiieva (JIRA)" <ji...@apache.org> on 2018/10/05 10:55:00 UTC
[jira] [Comment Edited] (CALCITE-2610) AssertionError when group by
ordinal in select star query
[ https://issues.apache.org/jira/browse/CALCITE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639655#comment-16639655 ]
Arina Ielchiieva edited comment on CALCITE-2610 at 10/5/18 10:54 AM:
---------------------------------------------------------------------
Currently we have 4 cases:
1. non-dynamic table, star select, group by named column: {{select * from dept group by deptno}}
Error: {{org.apache.calcite.runtime.CalciteContextException: At line 1, column 8: Expression 'DEPT.NAME' is not being grouped}}
2. non-dynamic table, star select, group by ordinal: {{select * from dept group by 1}}
Error: {{org.apache.calcite.runtime.CalciteContextException: At line 1, column 8: Unknown identifier '*'}}
3. dynamic table, star select, group by named column:
Error: {{org.apache.calcite.sql.validate.SqlValidatorException: Expression 'NATION.**' is not being grouped}}
4. non-dynamic table, star select, group by ordinal: {{select * from "SALES".NATION group by 1}}
Error: {{java.lang.AssertionError}}
PostgreSQL:
{noformat}
CREATE TABLE distributors (
id integer,
name varchar(40)
);
select * from distributors group by id;
select * from distributors group by 1;
ERROR: column "distributors.name" must appear in the GROUP BY clause or be used in an aggregate function Position: 8
{noformat}
Oracle:
{noformat}
select * from HR.DEPARTMENTS group by DEPARTMENT_ID;
ORA-00979: not a GROUP BY expression
{noformat}
I think we should throw an error by it should be something meaningful rather then assertion error.
was (Author: arina):
Currently we have 4 cases:
1. non-dynamic table, star select, group by named column: {{select * from dept group by deptno}}
Error: {{org.apache.calcite.runtime.CalciteContextException: At line 1, column 8: Expression 'DEPT.NAME' is not being grouped}}
2. non-dynamic table, star select, group by ordinal: {{select * from dept group by 1}}
Error: {{org.apache.calcite.runtime.CalciteContextException: At line 1, column 8: Unknown identifier '*'}}
3. dynamic table, star select, group by named column:
Error: {{org.apache.calcite.sql.validate.SqlValidatorException: Expression 'NATION.**' is not being grouped}}
4. non-dynamic table, star select, group by ordinal: {{select * from "SALES".NATION group by 1}}
Error: {{java.lang.AssertionError}}
PostgreSQL:
{noformat}
CREATE TABLE distributors (
id integer,
name varchar(40)
);
select * from distributors group by id;
select * from distributors group by 1;
ERROR: column "distributors.name" must appear in the GROUP BY clause or be used in an aggregate function Position: 8
{noformat}
Oracle:
{noformat}
select * from HR.DEPARTMENTS group by DEPARTMENT_ID;
ORA-00979: not a GROUP BY expression
{noformat}
> AssertionError when group by ordinal in select star query
> ---------------------------------------------------------
>
> Key: CALCITE-2610
> URL: https://issues.apache.org/jira/browse/CALCITE-2610
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Julian Hyde
> Priority: Major
>
> *Prerequisites:* Dynamic table, conformance that allows group by ordinal
> *Query:* {{SELECT * FROM SALES.NATION GROUP BY 1}}
> *Exception:*
> {noformat}
> java.lang.AssertionError
> at org.apache.calcite.sql.validate.SqlValidatorUtil.analyzeGroupExpr(SqlValidatorUtil.java:840)
> at org.apache.calcite.sql.validate.SqlValidatorUtil.convertGroupSet(SqlValidatorUtil.java:792)
> at org.apache.calcite.sql.validate.SqlValidatorUtil.analyzeGroupItem(SqlValidatorUtil.java:749)
> at org.apache.calcite.sql.validate.AggregatingSelectScope.resolve(AggregatingSelectScope.java:104)
> at org.apache.calcite.sql.validate.AggregatingSelectScope.lambda$new$0(AggregatingSelectScope.java:65)
> at com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:131)
> at org.apache.calcite.sql.validate.AggregatingSelectScope.getGroupExprs(AggregatingSelectScope.java:156)
> at org.apache.calcite.sql.validate.AggregatingSelectScope.checkAggregateExpr(AggregatingSelectScope.java:224)
> at org.apache.calcite.sql.validate.AggregatingSelectScope.validateExpr(AggregatingSelectScope.java:237)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateExpr(SqlValidatorImpl.java:4098)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList(SqlValidatorImpl.java:4072)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:3303)
> at org.apache.calcite.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:60)
> at org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:973)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:949)
> at org.apache.calcite.sql.SqlSelect.validate(SqlSelect.java:216)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:924)
> at org.apache.calcite.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:628)
> at org.apache.calcite.test.SqlToRelTestBase$TesterImpl.convertSqlToRel(SqlToRelTestBase.java:607)
> at org.apache.calcite.test.SqlToRelTestBase$TesterImpl.assertConvertsTo(SqlToRelTestBase.java:722)
> at org.apache.calcite.test.SqlToRelConverterTest$Sql.convertsTo(SqlToRelConverterTest.java:2944)
> at org.apache.calcite.test.SqlToRelConverterTest$Sql.ok(SqlToRelConverterTest.java:2936)
> at org.apache.calcite.test.SqlToRelConverterTest.testWindowAndGroupByWithDynamicStar(SqlToRelConverterTest.java:2672)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {noformat}
> Should throw meaningful exception instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)