[GitHub] [cloudstack] weizhouapache commented on pull request #4629: server: prevent update vm read-only details

[GitBox <gi...@apache.org>]

weizhouapache commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770742309


   > @weizhouapache I think changing global setting name would require DB change and doc changes, the feature/user of the change is only UI so I guess that's why the setting name has `ui` in it.
   
   
   
   > @shwstppr that PR also needs more attention to updates. I agree with the principle as this is not only UI but also API (which would be a security issue if it wasn't) as is this change lgtm
   
   @rhtyd @DaanHoogland 
    let's merge this, and change setting name afterwards as it requires sql change ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org