You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Anuhan Torgonshar (JIRA)" <ji...@apache.org> on 2019/03/06 13:31:00 UTC

[jira] [Updated] (YARN-9349) When doTransition() method occurs exception, the log level practices are inconsistent

     [ https://issues.apache.org/jira/browse/YARN-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anuhan Torgonshar updated YARN-9349:
------------------------------------
    Description: 
There are *inconsistent* log level practices when code catches *_InvalidStateTransitionException_* for _*doTransition()*_ method.
{code:java}
//file path: hadoop-3.1.0-src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
//log statement line number: 629
try {
   // queue event requesting init of the same app
   newState = stateMachine.doTransition(event.getType(), event);
} catch (InvalidStateTransitionException e) {
   LOG.warn("Can't handle this event at current state", e);
}


{code}

  was:There are *inconsistent* log level practices when code catches *_InvalidStateTransitionException_* for _*doTransition()*_ method.

        Summary: When doTransition() method occurs exception, the log level practices are inconsistent  (was: When doTransition() method occurs exception, the log level practices are incon)

> When doTransition() method occurs exception, the log level practices are inconsistent
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-9349
>                 URL: https://issues.apache.org/jira/browse/YARN-9349
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.1.0, 2.8.5
>            Reporter: Anuhan Torgonshar
>            Priority: Major
>
> There are *inconsistent* log level practices when code catches *_InvalidStateTransitionException_* for _*doTransition()*_ method.
> {code:java}
> //file path: hadoop-3.1.0-src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
> //log statement line number: 629
> try {
>    // queue event requesting init of the same app
>    newState = stateMachine.doTransition(event.getType(), event);
> } catch (InvalidStateTransitionException e) {
>    LOG.warn("Can't handle this event at current state", e);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org