[GitHub] [beam] TheNeuralBit commented on a change in pull request #17191: [BEAM-14157] GrpcWindmillServer: Use stream specific boolean to do client closed check

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #17191:
URL: https://github.com/apache/beam/pull/17191#discussion_r836670151



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -632,6 +632,8 @@ private static long uniqueId() {
     // The following should be protected by synchronizing on this, except for
     // the atomics which may be read atomically for status pages.
     private StreamObserver<RequestT> requestObserver;
+    // Indicates if the current stream in requestObserver is client closed

Review comment:
       Could you clarify the language here? I'm not sure what "is client closed" means

##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -742,10 +745,11 @@ public final void appendSummaryHtml(PrintWriter writer) {
         writer.format(", %dms backoff remaining", sleepLeft);
       }
       writer.format(
-          ", current stream is %dms old, last send %dms, last response %dms",
+          ", current stream is %dms old, last send %dms, last response %dms, closed: %s",
           debugDuration(nowMs, startTimeMs.get()),
           debugDuration(nowMs, lastSendTimeMs.get()),
-          debugDuration(nowMs, lastResponseTimeMs.get()));
+          debugDuration(nowMs, lastResponseTimeMs.get()),
+          streamClosed.get() ? "true" : "false");

Review comment:
       nit: this is the same as using `Boolean.toString`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org