You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/06 23:27:10 UTC
[GitHub] [nifi] thenatog opened a new pull request, #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…
thenatog opened a new pull request, #6492:
URL: https://github.com/apache/nifi/pull/6492
…ted using nc utility.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10604](https://issues.apache.org/jira/browse/NIFI-10604)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-10604`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-10604`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [x] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…
URL: https://github.com/apache/nifi/pull/6492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6492:
URL: https://github.com/apache/nifi/pull/6492#issuecomment-1270840367
I tested this idle connection timeout using the ListenTCP processor configured with a listen port of 10054, and the idle timeout set to 5 seconds. I ran the command "nc 127.0.0.1 10054", which opens a TCP connection to 10054, accepting text input from the command line. You can write a message as input to the command, hit return, and wait 5 seconds and the command will terminate, as the connection has been closed by ListenTCP. I believe also waiting 5 seconds and sending no message will also have the connection close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6492:
URL: https://github.com/apache/nifi/pull/6492#discussion_r990205077
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java:
##########
@@ -133,6 +135,15 @@ public class ListenTCP extends AbstractProcessor {
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+ protected static final PropertyDescriptor IDLE_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
+ .name("idle-timeout")
+ .displayName("Idle Connection Timeout")
+ .description("The amount of time a client's connection will remain open if no data is received. The default of 0 seconds will leave connections open until they are closed by the client.")
+ .required(false)
Review Comment:
With the default value matching current behavior, it looks like `required` should be `true`, which might also warrant adjusting the order of the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org