You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2026/01/20 09:13:56 UTC
[PR] [fix](cloud) fix table and partition get_version [doris]
mymeiyi opened a new pull request, #60064:
URL: https://github.com/apache/doris/pull/60064
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3772672384
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60064:
URL: https://github.com/apache/doris/pull/60064#discussion_r2707484590
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudPartition.java:
##########
@@ -251,16 +262,16 @@ public static List<Long> getSnapshotVisibleVersionFromMs(
// Return the visible version in order of the specified partition ids, -1 means version NOT FOUND.
public static List<Long> getSnapshotVisibleVersion(List<CloudPartition> partitions) throws RpcException {
if (partitions.isEmpty()) {
- return new ArrayList<>();
+ return Collections.emptyList();
}
if (SessionVariable.cloudPartitionVersionCacheTtlMs <= 0) { // No cached versions will be used
Review Comment:
Inconsistent access to cloudPartitionVersionCacheTtlMs. This line uses static access to SessionVariable.cloudPartitionVersionCacheTtlMs, but the isCachedVersionExpired() method (line 129) now uses instance access via ctx.getSessionVariable().cloudPartitionVersionCacheTtlMs. This creates inconsistent behavior. Either the field should be changed from static to instance in SessionVariable.java, or this access should be consistent with the other usage. Consider obtaining the session variable from ConnectContext like done in isCachedVersionExpired().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3776505983
# FE Regression Coverage Report
Increment line coverage ` 42.31% (11/26)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3777061730
# FE Regression Coverage Report
Increment line coverage ` 42.31% (11/26)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #60064:
URL: https://github.com/apache/doris/pull/60064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3783190788
# FE UT Coverage Report
Increment line coverage ` 51.85% (14/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_200fb6cd5ed795a8e7be7f1fb3af03674ed27105/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_200fb6cd5ed795a8e7be7f1fb3af03674ed27105/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60064:
URL: https://github.com/apache/doris/pull/60064#discussion_r2707586855
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -3301,8 +3302,9 @@ public boolean isCachedTableVersionExpired() {
return System.currentTimeMillis() - lastTableVersionCachedTimeMs > cacheExpirationMs;
}
- public void setCachedTableVersion(long version) {
- if (version > cachedTableVersion) {
+ @VisibleForTesting
+ protected void setCachedTableVersion(long version) {
+ if (version >= cachedTableVersion) {
Review Comment:
Changing the condition from `version > cachedTableVersion` to `version >= cachedTableVersion` breaks the existing test at line 380-386 of OlapTableTest.java. The test verifies that calling setCachedTableVersion with an equal or smaller version should NOT update the timestamp, preventing incorrect cache TTL resets. With this change, setting the same version will refresh the cache timestamp, which is not the intended behavior and will cause the test to fail.
```suggestion
if (version > cachedTableVersion) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudPartition.java:
##########
@@ -251,16 +261,18 @@ public static List<Long> getSnapshotVisibleVersionFromMs(
// Return the visible version in order of the specified partition ids, -1 means version NOT FOUND.
public static List<Long> getSnapshotVisibleVersion(List<CloudPartition> partitions) throws RpcException {
if (partitions.isEmpty()) {
- return new ArrayList<>();
+ return Collections.emptyList();
}
- if (SessionVariable.cloudPartitionVersionCacheTtlMs <= 0) { // No cached versions will be used
+ long cloudPartitionVersionCacheTtlMs = ConnectContext.get() == null ? 0
+ : ConnectContext.get().getSessionVariable().cloudPartitionVersionCacheTtlMs;
+ if (cloudPartitionVersionCacheTtlMs <= 0) { // No cached versions will be used
return getSnapshotVisibleVersionFromMs(partitions, false);
}
Review Comment:
Potential NullPointerException: `ConnectContext.get()` is called twice on lines 267-268. If the context becomes null between the first check and the second call, this will throw a NullPointerException. Store the result in a variable to avoid calling it twice.
```suggestion
ConnectContext ctx = ConnectContext.get();
long cloudPartitionVersionCacheTtlMs = ctx == null ? 0
: ctx.getSessionVariable().cloudPartitionVersionCacheTtlMs;
if (cloudPartitionVersionCacheTtlMs <= 0) { // No cached versions will be used
return getSnapshotVisibleVersionFromMs(partitions, false);
```
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -3367,14 +3369,21 @@ public static List<Long> getVisibleVersionInBatch(Collection<OlapTable> tables)
.collect(Collectors.toList());
}
- List<Long> dbIds = new ArrayList<>();
- List<Long> tableIds = new ArrayList<>();
+ List<Long> dbIds = new ArrayList<>(tables.size());
+ List<Long> tableIds = new ArrayList<>(tables.size());
for (OlapTable table : tables) {
dbIds.add(table.getDatabase().getId());
tableIds.add(table.getId());
}
- return getVisibleVersionFromMeta(dbIds, tableIds);
+ List<Long> versions = getVisibleVersionFromMeta(dbIds, tableIds);
+
+ // update cache
+ Preconditions.checkState(tables.size() == versions.size());
+ for (int i = 0; i < tables.size(); i++) {
+ tables.get(i).setCachedTableVersion(versions.get(i));
+ }
Review Comment:
The new cache update logic in lines 3381-3385 lacks test coverage. Since OlapTableTest.java already has comprehensive tests for cache behavior (testTableVersionCacheWithRpc), consider adding a test for getVisibleVersionInBatch to verify that the cache is correctly updated when fetching versions in batch mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3772115948
<details>
<summary>TPC-H: <b>Total hot run time: 31153 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53d4bf628dd6d3dbe233c813890820176f37bfaa, data reload: false
------ Round 1 ----------------------------------
q1 17593 4263 4079 4079
q2 2054 366 239 239
q3 10163 1285 715 715
q4 10195 795 305 305
q5 7510 2090 1797 1797
q6 191 168 139 139
q7 926 793 659 659
q8 9273 1368 1123 1123
q9 4846 4661 4538 4538
q10 6796 1796 1398 1398
q11 536 305 277 277
q12 778 739 627 627
q13 17799 3822 3126 3126
q14 291 289 269 269
q15 586 511 516 511
q16 754 746 631 631
q17 683 832 442 442
q18 7072 6437 6266 6266
q19 1340 977 619 619
q20 408 357 242 242
q21 3001 2435 2199 2199
q22 1037 1022 952 952
Total cold run time: 103832 ms
Total hot run time: 31153 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4103 4024 4011 4011
q2 322 394 317 317
q3 2109 2595 2271 2271
q4 1304 1743 1353 1353
q5 4128 4059 4017 4017
q6 222 169 128 128
q7 1841 1792 1662 1662
q8 2785 2463 2397 2397
q9 7407 7312 7203 7203
q10 2520 2708 2323 2323
q11 579 496 509 496
q12 708 769 660 660
q13 3549 4133 3500 3500
q14 290 313 287 287
q15 554 512 500 500
q16 655 727 637 637
q17 1212 1339 1382 1339
q18 8311 7847 7853 7847
q19 868 890 895 890
q20 1946 2034 1987 1987
q21 4834 4357 4203 4203
q22 1053 1016 952 952
Total cold run time: 51300 ms
Total hot run time: 48980 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3791470717
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3779178312
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3783078941
<details>
<summary>ClickBench: <b>Total hot run time: 26.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 200fb6cd5ed795a8e7be7f1fb3af03674ed27105, data reload: false
query1 0.06 0.05 0.05
query2 0.11 0.05 0.05
query3 0.25 0.09 0.08
query4 1.61 0.12 0.12
query5 0.28 0.27 0.26
query6 1.14 0.67 0.65
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.57 0.49 0.52
query10 0.55 0.56 0.55
query11 0.14 0.09 0.10
query12 0.14 0.11 0.11
query13 0.61 0.60 0.58
query14 0.95 0.93 0.95
query15 0.79 0.77 0.78
query16 0.40 0.39 0.39
query17 1.07 1.00 1.03
query18 0.23 0.21 0.21
query19 1.98 1.91 1.92
query20 0.02 0.01 0.01
query21 15.43 0.27 0.14
query22 4.99 0.05 0.05
query23 15.83 0.28 0.10
query24 1.38 0.79 0.30
query25 0.13 0.08 0.07
query26 0.14 0.14 0.13
query27 0.07 0.06 0.05
query28 4.30 1.08 0.88
query29 12.54 3.99 3.18
query30 0.28 0.15 0.12
query31 2.81 0.64 0.39
query32 3.25 0.56 0.46
query33 3.03 2.97 3.07
query34 15.96 5.12 4.39
query35 4.43 4.43 4.43
query36 0.67 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.05
query39 0.05 0.03 0.04
query40 0.18 0.15 0.14
query41 0.08 0.03 0.04
query42 0.04 0.03 0.04
query43 0.06 0.04 0.04
Total cold run time: 96.81 s
Total hot run time: 26.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3783588171
# FE Regression Coverage Report
Increment line coverage ` 77.78% (21/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_200fb6cd5ed795a8e7be7f1fb3af03674ed27105_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_200fb6cd5ed795a8e7be7f1fb3af03674ed27105_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3772179833
<details>
<summary>ClickBench: <b>Total hot run time: 26.79 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53d4bf628dd6d3dbe233c813890820176f37bfaa, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.04 0.04
query3 0.26 0.09 0.09
query4 1.61 0.12 0.11
query5 0.29 0.26 0.25
query6 1.15 0.66 0.65
query7 0.04 0.02 0.02
query8 0.05 0.04 0.04
query9 0.56 0.50 0.49
query10 0.54 0.54 0.55
query11 0.15 0.09 0.10
query12 0.14 0.10 0.10
query13 0.60 0.58 0.59
query14 0.95 0.95 0.96
query15 0.79 0.78 0.77
query16 0.40 0.40 0.38
query17 1.00 0.97 1.06
query18 0.22 0.21 0.21
query19 1.87 1.90 1.85
query20 0.02 0.02 0.01
query21 15.44 0.28 0.15
query22 5.19 0.05 0.05
query23 15.90 0.28 0.10
query24 1.95 0.25 0.53
query25 0.11 0.06 0.06
query26 0.14 0.13 0.13
query27 0.07 0.06 0.05
query28 4.37 1.07 0.88
query29 12.56 3.90 3.15
query30 0.27 0.14 0.14
query31 2.82 0.63 0.40
query32 3.24 0.56 0.46
query33 3.04 3.06 3.11
query34 16.37 5.11 4.42
query35 4.45 4.45 4.46
query36 0.66 0.51 0.48
query37 0.13 0.07 0.07
query38 0.07 0.04 0.03
query39 0.05 0.03 0.03
query40 0.16 0.14 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 97.97 s
Total hot run time: 26.79 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3776602899
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3783028642
<details>
<summary>TPC-H: <b>Total hot run time: 30876 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 200fb6cd5ed795a8e7be7f1fb3af03674ed27105, data reload: false
------ Round 1 ----------------------------------
q1 17632 4736 4550 4550
q2 2065 336 196 196
q3 10181 1274 738 738
q4 10221 858 311 311
q5 7526 2068 1823 1823
q6 186 165 141 141
q7 886 703 585 585
q8 9273 1395 1065 1065
q9 4819 4493 4634 4493
q10 6784 1668 1239 1239
q11 515 291 297 291
q12 348 375 228 228
q13 17797 3874 3099 3099
q14 241 234 213 213
q15 614 525 519 519
q16 644 641 589 589
q17 653 730 579 579
q18 6606 6468 6529 6468
q19 1272 954 647 647
q20 403 339 227 227
q21 2615 2065 1931 1931
q22 1059 1025 944 944
Total cold run time: 102340 ms
Total hot run time: 30876 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4732 4678 4665 4665
q2 317 389 315 315
q3 2155 2638 2280 2280
q4 1335 1789 1291 1291
q5 4092 3924 3980 3924
q6 223 174 134 134
q7 1952 1850 1735 1735
q8 2803 2505 2535 2505
q9 7205 7260 7040 7040
q10 2562 2711 2387 2387
q11 578 483 449 449
q12 691 752 625 625
q13 3649 4221 3622 3622
q14 291 315 272 272
q15 550 523 513 513
q16 638 689 627 627
q17 1160 1408 1458 1408
q18 8131 8111 7765 7765
q19 913 839 854 839
q20 2238 2011 1930 1930
q21 4893 4518 4202 4202
q22 1074 1016 955 955
Total cold run time: 52182 ms
Total hot run time: 49483 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3779178766
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3782904180
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3772160014
<details>
<summary>TPC-DS: <b>Total hot run time: 173859 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53d4bf628dd6d3dbe233c813890820176f37bfaa, data reload: false
query5 4483 663 493 493
query6 330 237 204 204
query7 4227 491 267 267
query8 359 241 240 240
query9 8757 2879 2898 2879
query10 531 370 359 359
query11 15084 15174 14831 14831
query12 179 120 112 112
query13 1263 496 398 398
query14 6217 3044 2777 2777
query14_1 2741 2651 2669 2651
query15 195 191 174 174
query16 987 495 458 458
query17 1086 672 551 551
query18 2464 441 337 337
query19 229 225 194 194
query20 118 118 114 114
query21 223 144 113 113
query22 3837 4147 3847 3847
query23 15921 15549 15293 15293
query23_1 15378 15530 15369 15369
query24 7181 1612 1169 1169
query24_1 1169 1166 1168 1166
query25 531 454 412 412
query26 1255 282 155 155
query27 2758 470 282 282
query28 4544 2190 2174 2174
query29 787 549 441 441
query30 311 233 199 199
query31 794 643 575 575
query32 90 79 80 79
query33 534 360 324 324
query34 960 919 523 523
query35 724 757 705 705
query36 837 880 806 806
query37 135 99 84 84
query38 2693 2773 2661 2661
query39 770 772 749 749
query39_1 707 741 722 722
query40 222 143 124 124
query41 73 70 66 66
query42 108 103 107 103
query43 482 491 407 407
query44 1372 760 757 757
query45 196 189 220 189
query46 888 993 573 573
query47 1386 1494 1330 1330
query48 311 333 242 242
query49 595 435 335 335
query50 644 273 205 205
query51 3814 3857 3799 3799
query52 103 107 96 96
query53 285 328 274 274
query54 288 264 279 264
query55 81 80 76 76
query56 304 295 298 295
query57 1007 1015 969 969
query58 271 250 255 250
query59 2029 2123 2000 2000
query60 327 326 316 316
query61 147 142 142 142
query62 377 337 300 300
query63 311 267 266 266
query64 4911 1270 917 917
query65 3797 3745 3759 3745
query66 1452 434 334 334
query67 15485 15628 15471 15471
query68 2381 1092 778 778
query69 451 353 328 328
query70 1011 965 871 871
query71 337 311 291 291
query72 5223 3286 3414 3286
query73 605 781 319 319
query74 8620 8654 8592 8592
query75 2842 2852 2454 2454
query76 2295 1140 652 652
query77 377 373 309 309
query78 9826 9995 9112 9112
query79 1074 953 604 604
query80 1315 564 479 479
query81 532 262 235 235
query82 1041 153 111 111
query83 373 264 240 240
query84 254 117 89 89
query85 890 486 414 414
query86 414 302 293 293
query87 2900 2871 2786 2786
query88 3474 2589 2563 2563
query89 395 358 322 322
query90 1954 172 155 155
query91 167 160 137 137
query92 83 73 75 73
query93 987 946 544 544
query94 637 322 310 310
query95 590 344 308 308
query96 647 528 230 230
query97 2366 2410 2342 2342
query98 227 207 196 196
query99 581 568 507 507
Total cold run time: 246270 ms
Total hot run time: 173859 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3773195101
# FE Regression Coverage Report
Increment line coverage ` 76.92% (20/26)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3783062158
<details>
<summary>TPC-DS: <b>Total hot run time: 172137 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 200fb6cd5ed795a8e7be7f1fb3af03674ed27105, data reload: false
query5 4461 644 499 499
query6 330 209 207 207
query7 4229 460 266 266
query8 352 249 248 248
query9 8723 2836 2791 2791
query10 440 330 288 288
query11 15068 15186 14881 14881
query12 172 121 124 121
query13 1249 465 375 375
query14 6020 2984 2755 2755
query14_1 2625 2617 2616 2616
query15 205 197 173 173
query16 991 483 451 451
query17 1114 695 579 579
query18 2437 446 341 341
query19 201 180 149 149
query20 122 119 116 116
query21 225 140 120 120
query22 3883 4000 4079 4000
query23 15868 15649 15344 15344
query23_1 15482 15329 15417 15329
query24 7163 1525 1124 1124
query24_1 1149 1144 1174 1144
query25 520 434 377 377
query26 1230 260 143 143
query27 2783 442 273 273
query28 4556 2143 2136 2136
query29 754 545 423 423
query30 315 232 202 202
query31 801 624 565 565
query32 86 73 73 73
query33 544 346 309 309
query34 876 865 526 526
query35 730 777 681 681
query36 828 939 838 838
query37 133 94 86 86
query38 2784 2764 2614 2614
query39 774 738 738 738
query39_1 715 731 722 722
query40 214 130 120 120
query41 67 62 65 62
query42 94 91 94 91
query43 472 477 414 414
query44 1301 751 732 732
query45 188 189 177 177
query46 817 948 574 574
query47 1433 1470 1259 1259
query48 308 313 232 232
query49 609 423 345 345
query50 670 264 199 199
query51 3700 3732 3655 3655
query52 88 90 79 79
query53 203 216 170 170
query54 288 260 250 250
query55 80 84 76 76
query56 292 300 308 300
query57 1006 1043 932 932
query58 269 260 258 258
query59 2162 2144 2052 2052
query60 339 338 311 311
query61 157 146 143 143
query62 382 358 320 320
query63 186 162 159 159
query64 4882 1149 852 852
query65 3889 3752 3690 3690
query66 1469 405 311 311
query67 15391 15533 15467 15467
query68 2497 1058 754 754
query69 398 330 281 281
query70 999 924 953 924
query71 300 286 261 261
query72 5303 3139 3217 3139
query73 581 717 307 307
query74 8687 8704 8511 8511
query75 2285 2350 1893 1893
query76 2257 1048 670 670
query77 354 382 330 330
query78 9636 9871 9198 9198
query79 1082 895 593 593
query80 629 523 457 457
query81 495 265 228 228
query82 1400 149 120 120
query83 364 261 241 241
query84 266 116 92 92
query85 826 480 411 411
query86 365 296 301 296
query87 2852 2869 2725 2725
query88 3468 2561 2544 2544
query89 302 267 243 243
query90 1870 170 164 164
query91 168 158 134 134
query92 76 78 70 70
query93 1057 1022 650 650
query94 450 315 294 294
query95 587 384 315 315
query96 639 507 230 230
query97 2370 2410 2307 2307
query98 218 199 205 199
query99 603 607 522 522
Total cold run time: 244151 ms
Total hot run time: 172137 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3771819992
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3771979635
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) fix table and partition get_version [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60064:
URL: https://github.com/apache/doris/pull/60064#issuecomment-3772738570
# FE Regression Coverage Report
Increment line coverage ` 76.92% (20/26)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60064_53d4bf628dd6d3dbe233c813890820176f37bfaa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org