You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2023/05/03 14:32:11 UTC
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19834
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
IMPALA-12113: Fix elapsed time calculation in query timeline
This patch changes the elapsed time at the bottom of the query timeline
to show the end of each interval. This was the original intention to use
the end time and right-align these values so that the full elapsed time
of the query is shown on the last interval. The query start time is
always implicitly 0 in the timeline.
Testing: Manually tested query in WebUI
Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
---
M www/query_timeline.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/19834/1
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12914/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 14:53:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9277/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 17:15:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
IMPALA-12113: Fix elapsed time calculation in query timeline
This patch changes the elapsed time at the bottom of the query timeline
to show the end of each interval. This was the original intention to use
the end time and right-align these values so that the full elapsed time
of the query is shown on the last interval. The query start time is
always implicitly 0 in the timeline.
Testing: Manually tested query in WebUI
Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Reviewed-on: http://gerrit.cloudera.org:8080/19834
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/query_timeline.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 22:35:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 16:19:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12113: Fix elapsed time calculation in query timeline
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19834 )
Change subject: IMPALA-12113: Fix elapsed time calculation in query timeline
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
Gerrit-Change-Number: 19834
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 17:15:33 +0000
Gerrit-HasComments: No