You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/15 21:44:38 UTC
[jira] [Commented] (AMQ-5662) Improve web console retry to support
all DLQ names
[ https://issues.apache.org/jira/browse/AMQ-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362547#comment-14362547 ]
ASF GitHub Bot commented on AMQ-5662:
-------------------------------------
GitHub user northlander opened a pull request:
https://github.com/apache/activemq/pull/73
AMQ-5662 Improve web console retry to support all DLQ names
https://issues.apache.org/jira/browse/AMQ-5662
Retry link in webconsole is changed from using move and pattern based DLQ identification to use AMQ built in DLQ query and retry mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/northlander/activemq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit 48d37a1c0cf2e6a4a7f1635bbad76b5a63d8ed42
Author: Petter Nordlander <no...@gmail.com>
Date: 2015-03-15T20:41:03Z
https://issues.apache.org/jira/browse/AMQ-5662 Changed retry command link behavior to use activemq built in retry mechanism in webconsole.
----
> Improve web console retry to support all DLQ names
> --------------------------------------------------
>
> Key: AMQ-5662
> URL: https://issues.apache.org/jira/browse/AMQ-5662
> Project: ActiveMQ
> Issue Type: Improvement
> Components: webconsole
> Affects Versions: 5.10.2, 5.11.1
> Reporter: Petter Nordlander
> Priority: Minor
> Labels: webconsole
>
> In web console, there is a "retry" link on a message when the name of browsed queue starts with DLQ. or DLT. The retry action in the console moves the letter to a queue named the same as the dead letter queue but without DLQ. or DLT.
> ActiveMQ, however, allows to use any name on a DLQ by using dead letter strategies. A shared strategy is the default, and the original destination is encoded in each message. The current implementation in web console cannot handle the default DLQ strategy in ActiveMQ, which has one single DLQ named ActiveMQ.DLQ.
> The suggested fix is to not rely on "move" to do a retry, but to use the built in retry mechanism instead. The second part of the fix is to only show the retry link when dealing with a real DLQ. A boolean is available through JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)