[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9662: [logging] deprecation notices for SQLite

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #9662:
URL: https://github.com/apache/incubator-superset/pull/9662#discussion_r416138728



##########
File path: superset/migrations/env.py
##########
@@ -34,10 +34,13 @@
 fileConfig(config.config_file_name)
 logger = logging.getLogger("alembic.env")
 
-
-config.set_main_option("sqlalchemy.url", current_app.config["SQLALCHEMY_DATABASE_URI"])
+DATABASE_URI = current_app.config["SQLALCHEMY_DATABASE_URI"]
+if "sqlite" in DATABASE_URI:
+    logger.warning("SQLite DB support may not be supported by in future version")

Review comment:
       Grammar nit: could we use "SQLite Database support for metadata databases will be removed in a future version of Superset."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org