You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/07/23 20:32:35 UTC
[jira] [Created] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Colin Patrick McCabe created HADOOP-8614:
--------------------------------------------
Summary: IOUtils#skipFully hangs forever on EOF
Key: HADOOP-8614
URL: https://issues.apache.org/jira/browse/HADOOP-8614
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.0.1-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
IOUtils#skipFully contains this code:
{code}
public static void skipFully(InputStream in, long len) throws IOException {
while (len > 0) {
long ret = in.skip(len);
if (ret < 0) {
throw new IOException( "Premature EOF from inputStream");
}
len -= ret;
}
}
{code}
The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438740#comment-13438740 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1173 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1173/])
HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8614:
--------------------------------
Priority: Minor (was: Major)
Target Version/s: 2.2.0-alpha (was: 2.0.1-alpha)
Affects Version/s: (was: 2.0.1-alpha)
2.0.0-alpha
Hadoop Flags: Reviewed
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8614:
-----------------------------------------
Status: Patch Available (was: Open)
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.1-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438263#comment-13438263 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2636 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2636/])
HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8614:
----------------------------------------
Fix Version/s: 0.23.3
I pulled this into 0.23.3 too.
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 0.23.3
>
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438252#comment-13438252 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2671 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2671/])
HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8614:
-----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 0.23.3
>
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438210#comment-13438210 ]
Eli Collins commented on HADOOP-8614:
-------------------------------------
+1 looks good, test failure is unrelated.
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438674#comment-13438674 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1141 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1141/])
HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438250#comment-13438250 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2607 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2607/])
HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375216)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8614:
-----------------------------------------
Attachment: HADOOP-8614.001.patch
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.1-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439459#comment-13439459 ]
Hudson commented on HADOOP-8614:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #351 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/351/])
svn merge -c 1375216 FIXES: HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe (Revision 1375572)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375572
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 0.23.3
>
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8614.
---------------------------------
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 0.23.3, 2.0.2-alpha
>
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on
EOF
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420896#comment-13420896 ]
Hadoop QA commented on HADOOP-8614:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537591/HADOOP-8614.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//console
This message is automatically generated.
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
> Key: HADOOP-8614
> URL: https://issues.apache.org/jira/browse/HADOOP-8614
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.1-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
> public static void skipFully(InputStream in, long len) throws IOException {
> while (len > 0) {
> long ret = in.skip(len);
> if (ret < 0) {
> throw new IOException( "Premature EOF from inputStream");
> }
> len -= ret;
> }
> }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF. However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception). So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira